Skip to content

feat(dashboard-ks-extension): migrate dataset-related pages and logic #5252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluid-e2e-bot merged 1 commit into from
Oct 3, 2025
Merged

feat(dashboard-ks-extension): migrate dataset-related pages and logic #5252

fluid-e2e-bot merged 1 commit into from
Oct 3, 2025

Conversation

@zmrlft
Copy link
Collaborator

@zmrlft zmrlft commented Sep 23, 2025 •
edited
Loading

Prerequisite: Please merge the PR #5250 first.

Ⅰ. Describe what this PR does

This PR migrates dataset-related pages and logic, including:

  • Migrating all contents under the pages/datasets/ directory (including components/, detail/, list/, etc.)
  • Migrating shared directory that is the common style of the data set, data loading, and runtime for their detail page resource status TAB page

The change only affects dataset-related pages and functionalities.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

No new test cases are added in this PR. The verification will focus on the normal rendering of dataset-related pages and the availability of core functionalities (create, view, delete), which can be validated through manual testing as described in the verification steps.

Ⅳ. Describe how to verify it

  1. Ensure this PR has been merged successfully
  2. Make sure you have KubeSphere version 4 installed in your environment
  3. Install Fluid in your cluster
  4. Add the required label to Fluid's CRDs using the following command: 
    # Example command to add label to Fluid dataset CRD
kubectl patch crd datasets.data.fluid.io --patch '{"metadata":{"labels":{"kubesphere.io/resource-served": "true"}}}'
  5. Run yarn install to install dependencies
  6. Run yarn dev to start the application
  7. Since specific pages (such as runtime and dataload pages) are missing, some route references may cause compilation or runtime errors (e.g., "module not found"). This is an expected behavior. During test verification, you can simply comment out the line of code that triggers the error; this issue will be fixed in subsequent PRs for page migration.
  8. Access dataset-related pages and verify that they render correctly without obvious errors
  9. Test core functionalities:
    • Try creating a new dataset
    • View dataset details
    • Delete an existing dataset
    • Verify that all these operations work as expected

Note: This plugin depends on KubeSphere's backend functions. By adding the kubesphere.io/resource-served: 'true' label, KubeSphere will provide pagination, fuzzy query APIs, and other features for related CR resources, which are essential for the proper functioning of this plugin.

Ⅴ. Special notes for reviews

  • Reviewers should focus on whether the dataset-related pages render correctly and if the core functionalities (create, view, delete) work properly

@zmrlft zmrlft force-pushed the feature/dashboard-ks-extension-dataset-pages-logic branch from 89b6441 to 11b5a37 Compare September 23, 2025 03:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 23, 2025

Quality Gate Passed Quality Gate passed

Issues
70 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
3.4% Duplication on New Code

See analysis details on SonarQube Cloud

@zmrlft zmrlft mentioned this pull request Sep 23, 2025
Merged
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Sep 24, 2025

Hi @zmrlft. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Oct 3, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.74%. Comparing base (c6dc844) to head (11b5a37).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5252      +/-   ##
==========================================
+ Coverage   55.50%   55.74%   +0.23%     
==========================================
  Files         443      443              
  Lines       30438    30445       +7     
==========================================
+ Hits        16896    16972      +76     
+ Misses      11978    11892      -86     
- Partials     1564     1581      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

RongGu
RongGu approved these changes Oct 3, 2025
View reviewed changes
Copy link
Member

@RongGu RongGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Oct 3, 2025
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Oct 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RongGu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 448d66d into fluid-cloudnative:master Oct 3, 2025
16 checks passed
Pikabooboo pushed a commit to Pikabooboo/fluid that referenced this pull request Oct 8, 2025
@zmrlft
feat(dashboard-ks-extension): migrate dataset-related pages and logic (…
c44123b 
…fluid-cloudnative#5252)

Signed-off-by: zmrlft <2643895326@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RongGu RongGu RongGu approved these changes

Assignees

@RongGu RongGu

Labels

approved lgtm needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zmrlft @RongGu