Skip to content

Conversation

@zmrlft
Copy link
Collaborator

@zmrlft zmrlft commented Sep 22, 2025

Prerequisite: Please merge the PR #5248 first.

Ⅰ. Describe what this PR does

This PR migrates the core framework, entry files and utility modules from the fluid-ks-extension. The specific migration content includes:

  • Migrating index.ts, App.tsx, and the directories: routes/, locales/, assets/, types/, utils/
  • Migrating common components under components/ (such as ClusterSelector.tsx, KVRecordInput.tsx, etc.)

Note that specific pages (pages/) and business logic are not migrated in this PR. This change introduces the basic framework, internationalization, routing, main entry and utility modules of Fluid Extension.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

No new test cases are added in this PR. The migration primarily involves core framework, entry files and common utilities without introducing new business logic.

Ⅳ. Describe how to verify it

  1. Ensure that the PR feat(dashboard-ks-extension): migrate base project structure and configs #5248 has been merged
  2. Run yarn install and verify that there are no errors during installation
  3. Make sure you have KubeSphere version 4 installed in your environment
  4. Configure the local runtime environment:
    Obtain the access address of the KubeSphere API Server (i.e., the IP and port of ks-apiserver)
    Open or create the local_config.yaml file in the configs directory and add the following configuration (replace the example URL with your actual KubeSphere API Server address):
server:
  apiServer:
    url: http://172.31.73.3:30880 # Replace with your ks-apiserver IP and port
    wsUrl: ws://172.31.73.3:30880 # Replace with your ks-apiserver IP and port
  1. Run yarn dev and you will encounter errors like module not found

Due to the absence of specific pages (such as datasets, runtimes, dataloads, etc.), some route and component references may cause compilation or runtime errors (e.g., "module not found"). This is an expected phenomenon that will be fixed in subsequent PRs for page migration.

Ⅴ. Special notes for reviews

  • The expected compilation/runtime errors mentioned in the verification steps are temporary and will be addressed in subsequent page migration PRs

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.50%. Comparing base (c6dc844) to head (9530694).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5250   +/-   ##
=======================================
  Coverage   55.50%   55.50%           
=======================================
  Files         443      443           
  Lines       30438    30438           
=======================================
  Hits        16896    16896           
  Misses      11978    11978           
  Partials     1564     1564           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Sep 24, 2025

Hi @zmrlft. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@RongGu RongGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RongGu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 8cffc34 into fluid-cloudnative:master Sep 30, 2025
20 of 21 checks passed
Pikabooboo pushed a commit to Pikabooboo/fluid that referenced this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants