-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(dashboard-ks-extension): migrate base project structure and configs #5248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard-ks-extension): migrate base project structure and configs #5248
Conversation
|
@zmrlft Please fix the issue of DCO by following https://github.com/fluid-cloudnative/fluid/pull/5248/checks?check_run_id=50882892371 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5248 +/- ##
=======================================
Coverage 55.50% 55.50%
=======================================
Files 443 443
Lines 30438 30438
=======================================
Hits 16896 16896
Misses 11978 11978
Partials 1564 1564 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: zmrlft <2643895326@qq.com>
0d76815 to
b815e9b
Compare
|
RongGu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RongGu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @zmrlft. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…igs (fluid-cloudnative#5248) Signed-off-by: zmrlft <2643895326@qq.com>



Ⅰ. Describe what this PR does
This PR migrates the basic engineering structure and dependencies from fluid-ks-extension. Specifically, it includes:
Note that the business code under the extensions/ directory is not migrated. This change only involves engineering configurations and dependencies, without affecting the main project's business code.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
No new test cases are added in this PR. Since the change only involves migration of engineering configuration files and dependencies without modifying business logic, the existing verification method (checking dependency installation) is sufficient to ensure the correctness of the migration.
Ⅳ. Describe how to verify it
To verify this PR, please perform the following steps:
yarn installcommandⅤ. Special notes for reviews