Skip to content

Conversation

@zmrlft
Copy link
Collaborator

@zmrlft zmrlft commented Sep 21, 2025

Ⅰ. Describe what this PR does

This PR migrates the basic engineering structure and dependencies from fluid-ks-extension. Specifically, it includes:

  • Migrating top-level engineering configuration files of fluid-ks-extension, such as package.json, tsconfig.json, babel.config.js, .editorconfig, .eslint*, .prettier* etc.
  • Migrating the configs/ directory (including webpack and other configuration files).

Note that the business code under the extensions/ directory is not migrated. This change only involves engineering configurations and dependencies, without affecting the main project's business code.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

No new test cases are added in this PR. Since the change only involves migration of engineering configuration files and dependencies without modifying business logic, the existing verification method (checking dependency installation) is sufficient to ensure the correctness of the migration.

Ⅳ. Describe how to verify it

To verify this PR, please perform the following steps:

  1. Check out this PR branch
  2. Run yarn install command
  3. Verify that the dependency installation completes successfully without any errors

Ⅴ. Special notes for reviews

  • This PR only focuses on configuration and dependency migration, so reviewers can focus on checking whether the migrated configuration files are complete and whether there are any conflicts with the current project's environment.
  • Since no business code is involved, there is no impact on the main project's functionality.

@RongGu
Copy link
Member

RongGu commented Sep 22, 2025

@zmrlft Please fix the issue of DCO by following https://github.com/fluid-cloudnative/fluid/pull/5248/checks?check_run_id=50882892371

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.50%. Comparing base (c6dc844) to head (b815e9b).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5248   +/-   ##
=======================================
  Coverage   55.50%   55.50%           
=======================================
  Files         443      443           
  Lines       30438    30438           
=======================================
  Hits        16896    16896           
  Misses      11978    11978           
  Partials     1564     1564           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zmrlft zmrlft force-pushed the feature/dashboard-ks-extension-base-structure branch from 0d76815 to b815e9b Compare September 22, 2025 05:26
@sonarqubecloud
Copy link

Copy link
Member

@RongGu RongGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RongGu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Sep 24, 2025

Hi @zmrlft. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fluid-e2e-bot fluid-e2e-bot bot merged commit cf213e9 into fluid-cloudnative:master Sep 24, 2025
16 checks passed
Pikabooboo pushed a commit to Pikabooboo/fluid that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants