Enhancement: refactor and unify checkFuseHealth implementation for all runtimes #4498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c4150a to
1a76b7a
Compare
Collaborator
cheyang
reviewed
Feb 14, 2025
cheyang
requested changes
Feb 14, 2025
pkg/ctrl/fuse.go
Outdated
| statusToUpdate.FuseNumberAvailable = int32(ds.Status.NumberAvailable) | ||
| if !reflect.DeepEqual(*statusToUpdate, currentStatus) { | ||
| if err := retry.RetryOnConflict(retry.DefaultBackoff, func() (err error) { | ||
| return e.client.Status().Update(context.TODO(), runtime) |
Collaborator
There was a problem hiding this comment.
I'm concerned that RetryOnConflict is used without incorporating the latest changes, it may repeatedly fail due to persistent conflicts.
fb16bec to
d6eb19f
Compare
…ple dataset failed status with fuse status Signed-off-by: jiuyu <guotongyu.gty@alibaba-inc.com>
d6eb19f to
a943089
Compare
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fluid-e2e-bot bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
* Enhancement: refactor and unify checkFuseHealth implementation, decouple dataset failed status with fuse status (#4498) Signed-off-by: jiuyu <guotongyu.gty@alibaba-inc.com> Co-authored-by: jiuyu <guotongyu.gty@alibaba-inc.com> Signed-off-by: JiGuoDing <485204300@qq.com> * Add Notation to UpdateDatasetStatus in pkg/ddc/jindo/dataset.go. Signed-off-by: JiGuoDing <485204300@qq.com> * Delete Notation of UpdateDatasetStatus in pkg/ddc/jindo/dataset.go. Signed-off-by: JiGuoDing <485204300@qq.com> * Add Notation to UpdateDatasetStatus in pkg/ddc/jindo/dataset.go. Signed-off-by: JiGuoDing <485204300@qq.com> * Modify annotation of UpdateDatasetStatus in pkg/ddc/jindo/dataset.go. Signed-off-by: JiGuoDing <485204300@qq.com> * Modify the comment format to double slashes. Signed-off-by: JiGuoDing <485204300@qq.com> --------- Signed-off-by: jiuyu <guotongyu.gty@alibaba-inc.com> Signed-off-by: JiGuoDing <485204300@qq.com> Co-authored-by: Syspretor <32930733+Syspretor@users.noreply.github.com> Co-authored-by: jiuyu <guotongyu.gty@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current code implementation, the runtime Interface requires each runtime to implement the
checkRuntimeHealthinterface, which is used to periodically verify whether the runtime is in a healthy state. Each runtime's implementation of this interface includes thecheckFuseHealthmethod, which checks the health status of the fuse daemonset. However, there are currently two issues with the checkFuseHealth implementation:checkFuseHealthmethod, but Fluid actually provides a common implementation for checkFuseHealth.This PR first refactors the common checkFuseHealth implementation. All runtimes now call this common function, and the main logic is consolidated into this common function. In this function, if the fuse daemonset status check fails, it will only result in a runtime warning event and will not cause the dataset to change to the failed status.