Add comments to UpdateDatasetStatus in pkg/ddc/jindo/dataset.go #4505
Conversation
|
Hi @JiGuoDing. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| // - phase (datav1alpha1.DatasetPhase): The new phase to update the dataset to. | ||
| // | ||
| // Returns: | ||
| // - err (error): Returns an error if the update process fails, otherwise returns nil. |
There was a problem hiding this comment.
I suggest using the following format to write multi-line comments in Go:
/*
UpdateDatasetStatus updates the phase and conditions of the dataset based on the given phase,
and updates the cache state based on the runtime status.
Parameters:
- phase (datav1alpha1.DatasetPhase): The new phase to update the dataset to.
Returns:
- err (error): Returns an error if the update process fails, otherwise returns nil.
*/|
@JiGuoDing Please fix DCO issue by following https://github.com/fluid-cloudnative/fluid/pull/4505/checks?check_run_id=37444364578 |
…ple dataset failed status with fuse status (#4498) Signed-off-by: jiuyu <guotongyu.gty@alibaba-inc.com> Co-authored-by: jiuyu <guotongyu.gty@alibaba-inc.com> Signed-off-by: JiGuoDing <485204300@qq.com>
Signed-off-by: JiGuoDing <485204300@qq.com>
Signed-off-by: JiGuoDing <485204300@qq.com>
Signed-off-by: JiGuoDing <485204300@qq.com>
Signed-off-by: JiGuoDing <485204300@qq.com>
|
Hello @cheyang, how about now? Is there anything else i need to do? |
Signed-off-by: JiGuoDing <485204300@qq.com>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks very much for your contribution! |
|
Add notation to UpdateDatasetStatus in pkg/ddc/jindo/dataset.go.