Support to configure the networkMode and podMetadata of vineyard components. #3981
Conversation
|
Hi @dashanji. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| } | ||
| expectedPortNum := expectedMasterPortNum + expectedWorkerPortNum | ||
|
|
||
| allocator, err := portallocator.GetRuntimePortAllocator() |
There was a problem hiding this comment.
May I know where do you use setupRuntimeAllocator to init?
There was a problem hiding this comment.
I think you should have the following code:
Cmd.Flags().StringVar(&portAllocatePolicy, "port-allocate-policy", "random", "Set port allocating policy, available choice is bitmap or random(default random).")
err = portallocator.SetupRuntimePortAllocator(mgr.GetClient(), pr, portAllocatePolicy, juicefs.GetReservedPorts)
if err != nil {
setupLog.Error(err, "failed to setup runtime port allocator")
os.Exit(1)
}There was a problem hiding this comment.
Sorry, it's my fault. I have not noticed the init function of the setupRuntimeAllocator. Thanks for pointing it out.
1ed4a04 to
c35e936
Compare
…onents. Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
c35e936 to
48632ed
Compare
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…onents. (fluid-cloudnative#3981) Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com> Signed-off-by: Ricky-Daxia <1915754435@qq.com>
Ⅰ. Describe what this PR does
Part of #3749