Skip to content

Support cache size of vineyard fuse and enable serverless mode for vineyard runtime #3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dashanji wants to merge 8 commits into from
Closed

Support cache size of vineyard fuse and enable serverless mode for vineyard runtime #3749

dashanji wants to merge 8 commits into from

Conversation

@dashanji
Copy link
Contributor

@dashanji dashanji commented Mar 4, 2024 •
edited
Loading

Ⅰ. Describe what this PR does

  • Support to configure the cache size of vineyard fuse.
  • Enable the serverless mode for vineyard runtime.
  • Support to configure the networkMode and podMetadata of vineyard components.
  • Add the related docs.

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cheyang for approval by writing /assign @cheyang in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dashanji dashanji changed the title Support serverless for vineyard Support serverless for Vineyard Runtime Mar 4, 2024
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Mar 4, 2024

Hi @dashanji. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Mar 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 64.21%. Comparing base (ebfb25a) to head (709f189).
Report is 17 commits behind head on master.

❗ Current head 709f189 differs from pull request most recent head f1cee86. Consider uploading reports for the commit f1cee86 to get more accurate results

Files Patch % Lines
pkg/application/inject/fuse/injector.go 71.42% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3749      +/-   ##
==========================================
- Coverage   64.29%   64.21%   -0.09%     
==========================================
  Files         476      474       -2     
  Lines       28327    28252      -75     
==========================================
- Hits        18214    18141      -73     
+ Misses       7947     7946       -1     
+ Partials     2166     2165       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dashanji dashanji force-pushed the support-serverless-for-vineyard branch from ccbbad4 to 3fdce33 Compare March 4, 2024 05:46
cheyang
cheyang reviewed Mar 4, 2024
View reviewed changes
pkg/common/constants.go Outdated
injectSidecar = ".sidecar" + inject
InjectServerless = "serverless" + inject // serverless.fluid.io/inject
InjectUnprivilegedFuseSidecar = "unprivileged" + injectSidecar // unprivileged.sidecar.fluid.io/inject
InjectVineyardSidecar = "vineyard" + injectSidecar // vineyard.sidecar.fluid.io/inject
Copy link
Collaborator

@cheyang cheyang Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if it's no need to set InjectVineyardSidecar by user. It should be determined automatically.

Copy link
Contributor Author

@dashanji dashanji Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I get it.

@dashanji dashanji force-pushed the support-serverless-for-vineyard branch from 47da8df to 709f189 Compare March 4, 2024 06:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
19.1% Duplication on New Code

See analysis details on SonarCloud

@dashanji
Copy link
Contributor Author

dashanji commented Mar 5, 2024

Hi @cheyang @TrafalgarZZZ , could you please take a look at this?

@dashanji dashanji force-pushed the support-serverless-for-vineyard branch from 709f189 to 3f5ebfc Compare April 10, 2024 07:26
@dashanji dashanji changed the title Support serverless for Vineyard Runtime Support cache size of vineyard fuse and enable serverless mode for Vineyard Runtime Apr 10, 2024
@dashanji dashanji changed the title Support cache size of vineyard fuse and enable serverless mode for Vineyard Runtime Support cache size of vineyard fuse and enable serverless mode for vineyard runtime Apr 10, 2024
dashanji added 4 commits April 10, 2024 15:30
@dashanji
Support to configure the cache size of vineyard fuse.
d095b3c 
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@dashanji
Add vineyard sidecar mutator and unit test.
abb2ff5 
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@dashanji
Update api.
f144119 
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@dashanji
Add the doc the cache-size of vineyard fuse and vineyard runtime on s…
80de31f 
…erverless mode.

Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@dashanji dashanji force-pushed the support-serverless-for-vineyard branch from 3f5ebfc to 80de31f Compare April 10, 2024 07:31
dashanji added 4 commits April 10, 2024 15:34
@dashanji
Generate open-api
a088022 
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@dashanji
Remove the vineyard worker socket when exit.
01b5cb3 
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@dashanji
Support to configure the networkMode and podMetadata of vineyard comp…
a18b2c5 
…onents.

Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@dashanji
Fix ci errors.
f1cee86 
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
21 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
20.9% Duplication on New Code

See analysis details on SonarCloud

@dashanji dashanji mentioned this pull request Apr 26, 2024
Merged
cheyang
cheyang requested changes Apr 26, 2024
View reviewed changes
pkg/application/inject/fuse/injector.go
}

// check whether the podSpecs is using vineyard runtime
func (s *Injector) checkVineyardPlatform(podSpecs *mutator.MutatingPodSpecs, runtimeInfos map[string]base.RuntimeInfoInterface) string {
Copy link
Collaborator

@cheyang cheyang Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Vineyard is a runtime not platform.

Copy link
Contributor Author

@dashanji dashanji Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this catch.

This was referenced Apr 26, 2024
Merged
Merged
@cheyang cheyang requested a review from TrafalgarZZZ May 8, 2024 03:44
@cheyang cheyang closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang requested changes

@TrafalgarZZZ TrafalgarZZZ Awaiting requested review from TrafalgarZZZ

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dashanji @cheyang