enhance: remove jindoruntime's fsGroup #3632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3632 +/- ##
=======================================
Coverage 64.26% 64.27%
=======================================
Files 443 443
Lines 26739 26749 +10
=======================================
+ Hits 17185 17193 +8
- Misses 7541 7542 +1
- Partials 2013 2014 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Member
Author
|
/test fluid-e2e |
cheyang
requested changes
Dec 11, 2023
| // the dataset is set to ReadWriteMany explicitly. | ||
| ufsVolumeReadOnly := true | ||
| accessModes := dataset.Spec.AccessModes | ||
| if len(accessModes) == 1 && accessModes[0] == corev1.ReadWriteMany { |
Member
Author
There was a problem hiding this comment.
ReadWriteOnce is now not supported for Fluid datasets.
cheyang
reviewed
Dec 11, 2023
| {{- else if .Values.nodeSelector }} | ||
| {{ toYaml .Values.nodeSelector | trim | indent 8 }} | ||
| {{- end }} | ||
| securityContext: |
Collaborator
There was a problem hiding this comment.
Please also update chart version and changelog. thanks.
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Kudos, SonarCloud Quality Gate passed!
|
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Dec 14, 2023
* Remove jindofsx's securityContext.fsGroup Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Dec 14, 2023
* Remove jindofsx's securityContext.fsGroup Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> Signed-off-by: cheyang <cheyang@163.com>
fluid-e2e-bot bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
* enhance: remove jindoruntime's fsGroup (#3632) * Remove jindofsx's securityContext.fsGroup Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> Signed-off-by: cheyang <cheyang@163.com> * Mount ufs volumes according to datasets' accessModes, To #53506158 Signed-off-by: cheyang <cheyang@163.com> * Mount ufs volumes according to datasets' accessModes, To #53506158 Signed-off-by: cheyang <cheyang@163.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> Signed-off-by: cheyang <cheyang@163.com> Co-authored-by: TzZtzt <trafalgarz@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
fsGrouprelated transformation in Jindofsx and JindoCache engine.fsGrouphas no critical effect on JindoRuntime's functionality but it will chown mounted persistent volumes which may cause unexpected changes on file ownership and permissions. See Configure volume permission and ownership change policy for Pods for more information:ReadWriteManyⅡ. Does this pull request fix one issue?
fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews