Skip to content

Conversation

@cheyang
Copy link
Collaborator

@cheyang cheyang commented Dec 14, 2023

  • Remove jindofsx's securityContext.fsGroup

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

* Remove jindofsx's securityContext.fsGroup

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>

---------

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: cheyang <cheyang@163.com>
@cheyang cheyang force-pushed the remove_fsgroup_0.9.3 branch from b6c3baf to e10172b Compare December 14, 2023 06:58
@codecov
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (69ca087) 65.43% compared to head (1ba935c) 65.43%.

Files Patch % Lines
pkg/ddc/jindofsx/transform.go 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           release-0.9    #3641   +/-   ##
============================================
  Coverage        65.43%   65.43%           
============================================
  Files              398      398           
  Lines            23151    23159    +8     
============================================
+ Hits             15149    15155    +6     
- Misses            6217     6219    +2     
  Partials          1785     1785           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheyang cheyang requested a review from TrafalgarZZZ December 14, 2023 07:18
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@cheyang
Copy link
Collaborator Author

cheyang commented Dec 14, 2023

/assign @TrafalgarZZZ

Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Dec 15, 2023
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 1f98a65 into fluid-cloudnative:release-0.9 Dec 15, 2023
@cheyang cheyang deleted the remove_fsgroup_0.9.3 branch January 17, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants