Skip to content

Conversation

@cheyang
Copy link
Collaborator

@cheyang cheyang commented Apr 5, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #2896

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: cheyang <cheyang@163.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #2897 (7ad593f) into master (9fc6a8e) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 7ad593f differs from pull request most recent head 2dfa383. Consider uploading reports for the commit 2dfa383 to get more accurate results

@@           Coverage Diff           @@
##           master    #2897   +/-   ##
=======================================
  Coverage   65.58%   65.58%           
=======================================
  Files         396      396           
  Lines       22798    22798           
=======================================
+ Hits        14951    14953    +2     
+ Misses       6098     6097    -1     
+ Partials     1749     1748    -1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Apr 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit b60859f into fluid-cloudnative:master Apr 6, 2023
fluid-e2e-bot bot pushed a commit that referenced this pull request Apr 11, 2023
* Add OpenSSF Scorecard for README.md (#2685)

Signed-off-by: fengshunli <1171313930@qq.com>
Signed-off-by: tartaglia <2602542817@qq.com>

* This pr is to add Apache License to transform_pvc_mounts_test.go (#2842)

Signed-off-by: Alian-g <2320341058@qq.com>
Signed-off-by: tartaglia <2602542817@qq.com>

* Download swagger-codegen-cli.jar in gen-sdk.sh (#2874)

* feature: download swagger-codegen-cli.jar in gen-sdk.sh

Signed-off-by: cqm <whqscqm@outlook.com>

* Revert "feature: download swagger-codegen-cli.jar in gen-sdk.sh"

This reverts commit 108648a.

Signed-off-by: cqm <whqscqm@outlook.com>

* update: adds more robustness and reliability to gen-sdk.sh

Signed-off-by: cqm <whqscqm@outlook.com>

---------

Signed-off-by: cqm <whqscqm@outlook.com>
Signed-off-by: tartaglia <2602542817@qq.com>

* change copyright's year (#2849)

Signed-off-by: mofumofuecho <2106975800@qq.com>
Signed-off-by: tartaglia <2602542817@qq.com>

* Delete swagger-codegen-cli.jar, To #46827170 (#2897)

Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: tartaglia <2602542817@qq.com>

* add Apache License

Signed-off-by: tartaglia <2602542817@qq.com>

* 1

Signed-off-by: tartaglia <2602542817@qq.com>

* add signoff

Signed-off-by: tartaglia <2602542817@qq.com>

---------

Signed-off-by: fengshunli <1171313930@qq.com>
Signed-off-by: tartaglia <2602542817@qq.com>
Signed-off-by: Alian-g <2320341058@qq.com>
Signed-off-by: cqm <whqscqm@outlook.com>
Signed-off-by: mofumofuecho <2106975800@qq.com>
Signed-off-by: cheyang <cheyang@163.com>
Co-authored-by: fsl <1171313930@qq.com>
Co-authored-by: Alian-g <79347453+Alian-g@users.noreply.github.com>
Co-authored-by: Twilight <48305952+BillyChen1@users.noreply.github.com>
Co-authored-by: mofumofuecho <100556081+mofumofuecho@users.noreply.github.com>
Co-authored-by: cheyang <cheyang@163.com>
@cheyang cheyang deleted the remove_swagger-codegen-cli.jar branch January 17, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove binary swagger-codegen-cli.jar

2 participants