Skip to content

LM #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluid-e2e-bot merged 9 commits into from
Apr 11, 2023
Merged

LM #2902

fluid-e2e-bot merged 9 commits into from
Apr 11, 2023

Conversation

@unknown-Tartaglia
Copy link
Contributor

@unknown-Tartaglia unknown-Tartaglia commented Apr 6, 2023

Ⅰ. Describe what this PR does

Add Apache License to pkg/utils/slice.go

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Apr 6, 2023

Hi @unknown-Tartaglia. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@TrafalgarZZZ
Copy link
Member

TrafalgarZZZ commented Apr 6, 2023

@unknown-Tartaglia Please fix the DCO check with git commit --signoff command

@TrafalgarZZZ
Copy link
Member

TrafalgarZZZ commented Apr 6, 2023

/self-assign

fengshunli and others added 8 commits April 9, 2023 19:46
@fengshunli @unknown-Tartaglia
Add OpenSSF Scorecard for README.md (#2685)
b5fa23a 
Signed-off-by: fengshunli <1171313930@qq.com>
Signed-off-by: tartaglia <2602542817@qq.com>
@Alian-g @unknown-Tartaglia
This pr is to add Apache License to transform_pvc_mounts_test.go (#2842)
2d86c46 
Signed-off-by: Alian-g <2320341058@qq.com>
Signed-off-by: tartaglia <2602542817@qq.com>
@BillyChen1 @unknown-Tartaglia
Download swagger-codegen-cli.jar in gen-sdk.sh (#2874)
2fe1e6c 
* feature: download swagger-codegen-cli.jar in gen-sdk.sh

Signed-off-by: cqm <whqscqm@outlook.com>

* Revert "feature: download swagger-codegen-cli.jar in gen-sdk.sh"

This reverts commit 108648a.

Signed-off-by: cqm <whqscqm@outlook.com>

* update: adds more robustness and reliability to gen-sdk.sh

Signed-off-by: cqm <whqscqm@outlook.com>

---------

Signed-off-by: cqm <whqscqm@outlook.com>
Signed-off-by: tartaglia <2602542817@qq.com>
@mofumofuecho @unknown-Tartaglia
change copyright's year (#2849)
086e8e1 
Signed-off-by: mofumofuecho <2106975800@qq.com>
Signed-off-by: tartaglia <2602542817@qq.com>
@cheyang @unknown-Tartaglia
Delete swagger-codegen-cli.jar, To #46827170 (#2897)
c98bbfa 
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: tartaglia <2602542817@qq.com>
@unknown-Tartaglia
add Apache License
0cd8f9c 
Signed-off-by: tartaglia <2602542817@qq.com>
@unknown-Tartaglia
1
7f0c023 
Signed-off-by: tartaglia <2602542817@qq.com>
@unknown-Tartaglia
add signoff
38ff8b4 
Signed-off-by: tartaglia <2602542817@qq.com>
@codecov
Copy link

codecov bot commented Apr 10, 2023 •
edited
Loading

Codecov Report

Merging #2902 (6d5d7be) into master (55ee585) will not change coverage.
The diff coverage is n/a.

❗ Current head 6d5d7be differs from pull request most recent head 7bdf4a1. Consider uploading reports for the commit 7bdf4a1 to get more accurate results

@@           Coverage Diff           @@
##           master    #2902   +/-   ##
=======================================
  Coverage   65.58%   65.58%           
=======================================
  Files         396      396           
  Lines       22798    22798           
=======================================
  Hits        14951    14951           
  Misses       6098     6098           
  Partials     1749     1749
Impacted Files Coverage Δ
pkg/utils/slice.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cheyang
Copy link
Collaborator

cheyang commented Apr 11, 2023

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Apr 11, 2023
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Apr 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit b5b6fa2 into fluid-cloudnative:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

Labels

approved lgtm needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@unknown-Tartaglia @TrafalgarZZZ @cheyang @fengshunli @Alian-g @BillyChen1 @mofumofuecho