Skip to content

Conversation

@IT-VBFK
Copy link
Contributor

@IT-VBFK IT-VBFK commented Oct 19, 2023

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks a bit unconventional.

@IT-VBFK
Copy link
Contributor Author

IT-VBFK commented Oct 20, 2023

As I mentioned in 2393.. it's a propsal 😉

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
@jnyrup jnyrup merged commit 63c96fa into fluentassertions:develop Oct 20, 2023
@IT-VBFK IT-VBFK deleted the fix/release-notes branch October 21, 2023 09:51
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
* Add release notes for fluentassertions#2393

* Update releases.md

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

---------

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
* Add release notes for fluentassertions#2393

* Update releases.md

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

---------

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
* Add release notes for fluentassertions#2393

* Update releases.md

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

---------

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
* Add release notes for fluentassertions#2393

* Update releases.md

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

---------

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
* Add release notes for fluentassertions#2393

* Update releases.md

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

---------

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
jnyrup added a commit that referenced this pull request Sep 9, 2024
* Add release notes for #2393

* Update releases.md

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

---------

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants