Skip to content

Pass Boolean literals as becauseArguments #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnyrup merged 1 commit into from
Oct 19, 2023
Merged

Pass Boolean literals as becauseArguments #2393

jnyrup merged 1 commit into from
Oct 19, 2023

Conversation

@jnyrup
Copy link
Member

@jnyrup jnyrup commented Oct 18, 2023

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

coveralls commented Oct 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6571421878

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.397%
Totals Coverage Status
Change from base Build 6571212407: 0.0%
Covered Lines: 11655
Relevant Lines: 11846
💛 - Coveralls

@eNeRGy164
Copy link
Contributor

eNeRGy164 commented Oct 18, 2023 •
edited
Loading

Would this eliminate the possibility to have your own Boolean formatters and influence the output?

@dennisdoomen
Copy link
Member

dennisdoomen commented Oct 18, 2023

Would this eliminate the possibility to have your own Boolean formatters and influence the output?

Never thought about that. But I suspect it would require changes to a lot more places.

@jnyrup
Copy link
Member Author

jnyrup commented Oct 18, 2023

Would this eliminate the possibility to have your own Boolean formatters and influence the output?

Never thought about that. But I suspect it would require changes to a lot more places.

As far as I can tell it's only BeTrue, BeFalse, NotBeTrue and NotBeFalse that have constant Booleans.
So I could as well change this PR to inject the literals into FailWith to let any potential BooleanFormatter pick them up and format them.

@ITaluone
Copy link
Contributor

ITaluone commented Oct 18, 2023

So I could as well change this PR to inject the literals into FailWith to let any potential BooleanFormatter pick them up and format them.

That would be cool :)

@jnyrup jnyrup force-pushed the no_format_of_constant_Booleans branch from fb4468f to 1698082 Compare October 19, 2023 07:17
@jnyrup jnyrup changed the title Manually format Boolean literals Pass Boolean literals as becauseArguments Oct 19, 2023
@jnyrup
Pass Boolean literals as becauseArguments
861a2b7 
This allows any potential BooleanFormatter to format them
@jnyrup jnyrup force-pushed the no_format_of_constant_Booleans branch from 1698082 to 861a2b7 Compare October 19, 2023 07:42
@jnyrup jnyrup merged commit eb23c36 into fluentassertions:develop Oct 19, 2023
@jnyrup jnyrup deleted the no_format_of_constant_Booleans branch October 19, 2023 08:26
@IT-VBFK
Copy link
Contributor

IT-VBFK commented Oct 19, 2023 •
edited
Loading

Should this also go the release notes? I think instead of the latest ("Capitalize true and false...")?

Proposal in #2396

IT-VBFK added a commit to IT-VBFK/fluentassertions that referenced this pull request Oct 19, 2023
@IT-VBFK
Add release notes for fluentassertions#2393
4f49fa1
jnyrup added a commit that referenced this pull request Oct 20, 2023
@IT-VBFK @jnyrup
Add release notes for #2393 (#2396)
63c96fa 
* Add release notes for #2393

* Update releases.md

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

---------

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@IT-VBFK @jnyrup
Add release notes for fluentassertions#2393 (fluentassertions#2396)
3948d28 
* Add release notes for fluentassertions#2393

* Update releases.md

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

---------

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@IT-VBFK @jnyrup
Add release notes for fluentassertions#2393 (fluentassertions#2396)
5c5b05e 
* Add release notes for fluentassertions#2393

* Update releases.md

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

---------

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@IT-VBFK @jnyrup
Add release notes for fluentassertions#2393 (fluentassertions#2396)
5bf7741 
* Add release notes for fluentassertions#2393

* Update releases.md

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

---------

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
@IT-VBFK @jnyrup
Add release notes for fluentassertions#2393 (fluentassertions#2396)
595fac3 
* Add release notes for fluentassertions#2393

* Update releases.md

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

---------

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
jnyrup added a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
@IT-VBFK @jnyrup
Add release notes for fluentassertions#2393 (fluentassertions#2396)
5fc4884 
* Add release notes for fluentassertions#2393

* Update releases.md

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

---------

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
jnyrup added a commit that referenced this pull request Sep 9, 2024
@IT-VBFK @jnyrup
Add release notes for #2393 (#2396)
fc3a2e4 
* Add release notes for #2393

* Update releases.md

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>

---------

Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 30, 2025
Merged
Closed
Closed
Open
Open
Open
Open
Open
Closed
Closed
This was referenced Jan 7, 2026
Closed
Closed
Open
Merged
Closed
Merged
Closed
Closed
Merged
Open
Open
Closed
Open
Open
Open
Open
This was referenced Jan 14, 2026
Open
Merged
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jnyrup @coveralls @eNeRGy164 @dennisdoomen @ITaluone @IT-VBFK