Update all of jest 29.7.0 → 30.0.0 (major) #5495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b53116 to
6377174
Compare
Member
|
@depfu recreate |
948c804 to
47859c2
Compare
9ce5123 to
f61eacd
Compare
Member
|
@julienw I updated the PR so the tests pass. Could you take a look? |
julienw
approved these changes
Jun 26, 2025
Contributor
julienw
left a comment
There was a problem hiding this comment.
thanks this looks good to me!
Jest version 30 page mentions this as a known issue: https://jestjs.io/blog/2025/06/04/jest-30#known-issues It looks like the new version of jsdom made window.location non-configurable. This is not great because we mock it in our tests since jsdom/jest doesn't provide everything we want. Unfortunately jsdom is not very positive on fixing this. See: jsdom/jsdom#3492
…roperties Previously MouseEvent in jsdom didn't have attributes like pageX,pageY. Now it supports it, but these properties only have getters and not setters. That's why we are overriding these properties with Object.defineProperties to fix the errors.
It looks like background css property wasn't added properly before even though this property was always added. New version of JSDOM seems like fixed it.
f61eacd to
a15db04
Compare
Member
|
Thanks for the review! I resolved the merge conflicts and deduplicated the packages. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5495 +/- ##
==========================================
- Coverage 86.11% 86.11% -0.01%
==========================================
Files 308 308
Lines 29652 29652
Branches 8001 8001
==========================================
- Hits 25536 25534 -2
- Misses 3526 3528 +2
Partials 590 590 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
canova
added a commit
that referenced
this pull request
Jul 11, 2025
Changes: [Nazım Can Altınova] Fix issues related to the track borders (#5484) [Nazım Can Altınova] Remove the active tab and origins views (#5483) [Julien Wajsberg] Automatically request reviews for dependency updates (#5490) [Julien Wajsberg] Update fetch-mock-jest to @fetch-mock/jest (#5488) [Steve Fink] Document marker filter syntax (#5493) [Nazım Can Altınova] Update all of jest 29.7.0 → 30.0.0 (major) (#5495) [Nazım Can Altınova] Order global tracks by activity and select the most active non-parent process by default (#5491) [Paul Adenot] Allow searching for HTTP response status in marker views (#5504) [Nazım Can Altınova] Expose a `totalMarkerDuration` function in console (#5507) [Nazım Can Altınova] 🔃 Sync: l10n -> main (July 11, 2025) (#5510) And thanks to our localizers: el: Jim Spentzos kab: ZiriSut tr: Grk tr: Selim Şumlu uk: Artem Polivanchuk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ babel-jest (29.7.0 → 30.0.0) · Repo · Changelog
Release Notes
30.0.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
✳️ jest (29.7.0 → 30.0.0) · Repo · Changelog
Release Notes
30.0.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
✳️ jest-environment-jsdom (29.7.0 → 30.0.0) · Repo · Changelog
Release Notes
30.0.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands