-
Notifications
You must be signed in to change notification settings - Fork 452
Deploy July 11, 2025 #5511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Deploy July 11, 2025 #5511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ZiriSut <rgebbid@gmail.com> (kab)
Co-authored-by: Selim Şumlu <selim@sum.lu> (tr)
Co-authored-by: Selim Şumlu <selim@sum.lu> (tr)
Co-authored-by: Grk <gu0townkg@relay.firefox.com> (tr)
Previously it was doing a lot more `calc`s because it was happening in the parent div. This commit changes the box-shadow into an inset box-shadow so we don't have to change the width all the time. But we still need to change the width once to remove the left border for the local tracks.
…ldren instead Adding the border to the children, so we can right click on the left track label and that would still open the context menu.
This PR fixes these track border/horizontal separator issues: First commit fixes the issue where it's not right clickable on the blue active thread indicator. It also tries to simplify this indicator by removing a bunch of `calc`s. Second commit fixes the issue that it's not right clickable on the top border of the thread label.
Previously we were returning an object with hovered marker index and label index. But we don't need that anymore since that was active tab only feature. Now we can revert this and simply return a number instead of returning an object and doing shallow object equality check.
Co-authored-by: Jim Spentzos <jimspentzos2000@gmail.com> (el)
Co-authored-by: Jim Spentzos <jimspentzos2000@gmail.com> (el)
Co-authored-by: Jim Spentzos <jimspentzos2000@gmail.com> (el)
Previously we were ordering the global tracks their global track order by type. But if both global tracks were processes, we were simply keeping the initial thread order. Now we sort the process global tracks by their activity.
Previously we were only getting the first tab process main thread as the selected thread, which wasn't the track we want most of the time.
…al sorting behavior This created some test changes how we find the selected thread in comparison profiles especially. But after thinking about it, I decided that the new behavior is actually better for them. Previously we were always getting the first track, but now we are getting the crowded one, which is usually the diffing track.
… process by default (#5491) Previously we were keeping the original order in the profile data structure when we were initializing the global track order, and selecting the first tab visible process by default. But this was mostly incorrect for the cases where we have more than one visible tab process, because usually busier thread arrives later during the profile collection. This should help our users to see the most active process very quickly instead of having to scroll down every time.
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Co-authored-by: Artem Polivanchuk <a.polivanchuk@outlook.com> (uk)
Updated locales: el, kab, tr, uk. Thanks to our localizers for their contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
[Nazım Can Altınova] Fix issues related to the track borders (#5484)
[Nazım Can Altınova] Remove the active tab and origins views (#5483)
[Julien Wajsberg] Automatically request reviews for dependency updates (#5490)
[Julien Wajsberg] Update fetch-mock-jest to @fetch-mock/jest (#5488)
[Steve Fink] Document marker filter syntax (#5493)
[Nazım Can Altınova] Update all of jest 29.7.0 → 30.0.0 (major) (#5495)
[Nazım Can Altınova] Order global tracks by activity and select the most active non-parent process by default (#5491)
[Paul Adenot] Allow searching for HTTP response status in marker views (#5504)
[Nazım Can Altınova] Expose a
totalMarkerDurationfunction in console (#5507)[Nazım Can Altınova] 🔃 Sync: l10n -> main (July 11, 2025) (#5510)
And thanks to our localizers:
el: Jim Spentzos
kab: ZiriSut
tr: Grk
tr: Selim Şumlu
uk: Artem Polivanchuk