Skip to content

Update angular example to modern standards#9583

Merged
tonybaroneee merged 1 commit intocrashlyticsfrom
update-angular-doc
Feb 20, 2026
Merged

Update angular example to modern standards#9583
tonybaroneee merged 1 commit intocrashlyticsfrom
update-angular-doc

Conversation

@tonybaroneee
Copy link

@tonybaroneee tonybaroneee commented Feb 20, 2026

No description provided.

@tonybaroneee tonybaroneee requested review from a team as code owners February 20, 2026 19:49
@changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: b3de4ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 20, 2026

Summary of Changes

Hello @tonybaroneee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the Angular integration examples for Firebase Crashlytics by transitioning from the traditional @NgModule setup to the more contemporary ApplicationConfig method. This change ensures that all provided code snippets and documentation reflect current Angular best practices, making it easier for developers to integrate Crashlytics into modern Angular applications.

Highlights

  • Angular Configuration Update: Updated Angular code examples in both documentation and source files to use the modern ApplicationConfig approach for providing FirebaseErrorHandler, moving away from the older @NgModule based configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • docs-devsite/crashlytics_angular.firebaseerrorhandler.md
    • Updated Angular configuration examples to use ApplicationConfig instead of @NgModule.
  • packages/crashlytics/src/angular/index.ts
    • Updated JSDoc code examples to use ApplicationConfig for provider configuration.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 20, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Angular examples for FirebaseErrorHandler to use the modern standalone application configuration (appConfig) instead of NgModule. The changes are in the right direction, but the new examples contain syntax errors and are missing a necessary import, which would prevent them from working if copied by a user. I've left specific comments with suggestions to fix these issues.

@tonybaroneee tonybaroneee merged commit 827de8b into crashlytics Feb 20, 2026
33 of 34 checks passed
@tonybaroneee tonybaroneee deleted the update-angular-doc branch February 20, 2026 20:08
@firebase firebase deleted a comment from triplegstore5241 Feb 21, 2026
MaesterChestnut pushed a commit that referenced this pull request Feb 26, 2026
@tonybaroneee
Update angular example to modern standards (#9583)
481a027
MaesterChestnut added a commit that referenced this pull request Feb 27, 2026
@MaesterChestnut @google-admin
@benknutson-google @dependabot @renovate @hsubox76 @anitdas @tonybaroneee @morganchen12
Crash tracing rebase (#9600)
e2608ae 
* Refactor Github Action per b/485167538 (#9555)

Co-authored-by: Ben Knutson <benknutson@google.com>

* build(deps): bump lodash in /packages/auth-compat/demo/functions (#9482)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.21...4.17.23)

---
updated-dependencies:
- dependency-name: lodash
  dependency-version: 4.17.23
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump lodash in /packages/auth-compat/demo (#9464)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.21...4.17.23)

---
updated-dependencies:
- dependency-name: lodash
  dependency-version: 4.17.23
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump lodash in /packages/rules-unit-testing/functions (#9463)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.21...4.17.23)

---
updated-dependencies:
- dependency-name: lodash
  dependency-version: 4.17.23
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump lodash in /packages/auth/demo/functions (#9466)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.21...4.17.23)

---
updated-dependencies:
- dependency-name: lodash
  dependency-version: 4.17.23
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): update dependency webpack-dev-server to v5.2.1 [security] (#9078)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update google-github-actions/auth digest to fc21748 (#8879)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* build(deps-dev): bump lodash from 4.17.21 to 4.17.23 (#9465)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.21...4.17.23)

---
updated-dependencies:
- dependency-name: lodash
  dependency-version: 4.17.23
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Remove health metrics workflows (#9571)

* feat(ai): Automatic function calling (#9489)

* Updating otel dependencies

* format

* Updating otel dependencies

* Remove fetch and user interaction libaries

* Removing node tracing

* format

* Update angular example to modern standards (#9583)

* chore(deps): update dependency @rollup/plugin-strip to v3 (#8745)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @rollup/plugin-virtual to v3 (#8771)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Use environment for wdr tokens (#9578)

* use environment for wdr tokens

* missed a file

* fix(deps): update dependency @rushstack/node-core-library to v5 (#8816)

* fix(deps): update dependency @rushstack/node-core-library to v5

* Fix method name

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Christina Holland <chholland@google.com>

* Update logs endpoint w/ location (fixed to `global` for now)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Google Admin <github-admin@google.com>
Co-authored-by: Ben Knutson <benknutson@google.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Christina Holland <chholland@google.com>
Co-authored-by: Anit Das <anitdas@google.com>
Co-authored-by: Anthony Barone <tonybaroneee@gmail.com>
Co-authored-by: Morgan Chen <morganchen12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anitdas anitdas Awaiting requested review from anitdas

@andrewbrook andrewbrook Awaiting requested review from andrewbrook

@MaesterChestnut MaesterChestnut Awaiting requested review from MaesterChestnut

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tonybaroneee