Crash tracing rebase#9600
Conversation
Co-authored-by: Ben Knutson <benknutson@google.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…9463) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
#9078) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* use environment for wdr tokens * missed a file
* fix(deps): update dependency @rushstack/node-core-library to v5 * Fix method name --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christina Holland <chholland@google.com>
|
Summary of ChangesHello @MaesterChestnut, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the AI SDK by integrating automatic function calling into the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces automatic function calling for the AI ChatSession and includes several updates to Crashlytics tracing, mainly by upgrading OpenTelemetry dependencies.
My review focuses on these areas. I've found a few issues:
- There is a recurring typo
maxSequentalFunctionCallsin the new public API for AI function calling. This should be corrected tomaxSequentialFunctionCallsacross all files. - The Crashlytics tracing setup has removed
FetchInstrumentationandUserInteractionInstrumentation. This could be a significant reduction in tracing capabilities, and it would be good to clarify if this is intentional. - The custom
OTLPLogExporterhas placeholder implementations forshutdown()andforceFlush()that should be corrected to ensure proper behavior, like preventing log loss on shutdown.
I've left specific comments with suggestions on the relevant files.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/ai/src/types/requests.ts (255-263)
There's a typo in maxSequentalFunctionCalls. It should be maxSequentialFunctionCalls (sequential, not sequental). This typo appears in multiple places in the codebase (API definitions, implementation, tests, and documentation). Since this is part of the public API, it's important to correct it before it gets released.
/**
* Limits amount of sequential function calls the SDK can make during automatic
* function calling, in order to prevent infinite loops. If not specified,
* this value defaults to 10.
*
* When it reaches this limit, it will return the last response received
* from the model, whether it is a text response or further function calls.
*/
maxSequentialFunctionCalls?: number;
packages/crashlytics/src/tracing/tracing-provider.ts (85-87)
This change removes FetchInstrumentation and UserInteractionInstrumentation. This means that fetch requests and user interactions will no longer be automatically traced. Is this removal intentional? If so, it would be good to document the reasoning behind this change in the PR description as it seems like a significant reduction in tracing capabilities.
packages/crashlytics/src/logging/logger-provider.ts (126-134)
The implementations for shutdown and forceFlush seem to be placeholders that only log to the console. This is misleading and can cause issues.
For shutdown, it should call super.shutdown() to ensure the base exporter is properly shut down, which is crucial for preventing data loss.
For forceFlush, a simple return Promise.resolve(); would be more appropriate, as this method is often a no-op in exporters that don't buffer, and logging to console is unnecessary noise.
async shutdown(): Promise<void> {
return super.shutdown();
}
async forceFlush(): Promise<void> {
return Promise.resolve();
}
Merge latest crashlytics branch into crashlytics-tracing