Ensure Implementation stategy captured in the KEP matches latest implementation#3
Merged
ffromani merged 1 commit intoffromani:cpumanager-policies-thread-placementfrom Apr 23, 2021
swatisehgal:update-imple-details
Merged
Ensure Implementation stategy captured in the KEP matches latest implementation#3ffromani merged 1 commit intoffromani:cpumanager-policies-thread-placementfrom swatisehgal:update-imple-details
ffromani merged 1 commit intoffromani:cpumanager-policies-thread-placementfrom
swatisehgal:update-imple-details
Conversation
…ementation Recent identification of a bug in the resourceAdmitHandlers Admit handler, led to changes in the implementation whereby ContainerManagerAdmissionError is no longer returned. This patch ensures that implementation strategy captured in the KEP matches the latest smtaware CPUManager implementation. Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
ffromani
pushed a commit
that referenced
this pull request
Sep 27, 2022
chore: rename to `key_id` and use bytes for metadata
ffromani
pushed a commit
that referenced
this pull request
May 3, 2023
…ategy (kubernetes#3661) * Initial KEP for improving pruning in kubectl apply * Add design details Co-authored-by: Katrina Verey <katrina.verey@shopify.com> * Add another open question * Links, clarifications, ownerRef and GKNN explanations * Follow-on to initial feedback, address some unresolved blocks * Fix lint errors * Add more detail about reference implementation (#2) * Apply prune jan25 (#3) * More clearly delineate specification vs kubectl details * Move design details of spec to Design Details section * Updates from synchronous conversation * Remove leftover paragraph (#5) Not an alternative rejected any more, given applyset.k8s.io/inventory * Justin has always been coauthor * KEP-3659: production readiness etc (#4) Fill in the testing/ PRR sections. * Fix test failures * Prune: document confused deputy attack and mitigations Likely pushes us to GKNN-derived IDs. * Constrain applyset id We just choose the constrained applyset id to prevent "applyset ID impersonation". * Update KEP and PRR metadata * Enhance testing description * ID vs name fixes * Fixes from soltysh's review --------- Co-authored-by: Justin Santa Barbara <justinsb@google.com>
ffromani
pushed a commit
that referenced
this pull request
Jul 16, 2023
address review feedback (part 2)
ffromani
pushed a commit
that referenced
this pull request
Oct 7, 2025
…dation-gen (kubernetes#5074) * KEP-5073: Declarative Validation of Kubernetes Native Types With validation-gen * resolving KEP comments * resolving KEP comments round #2 * resolving KEP comments round #3 * update KEP-5073 to clarify migration details * fix prototype link in a # of places * Propose a runtime verification check * Update TOC * move runtime check section * plumb DeclarativeValidationMismatchMetrics feature gate through KEP * resolving KEP comments round #4 * update reviewers and approvers * resolving KEP comments round #5 * resolving KEP comments round #6 * remove recommended and unresovled from zero values + defaulting section * fix metric name --------- Co-authored-by: yongruilin <yongrlin@outlook.com> Co-authored-by: Joe Betz <jpbetz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent identification of a bug in the resourceAdmitHandlers Admit handler,
led to changes in the implementation whereby ContainerManagerAdmissionError
is no longer returned. This patch ensures that implementation strategy
captured in the KEP matches the latest smtaware CPUManager implementation.
Signed-off-by: Swati Sehgal swsehgal@redhat.com