Skip to content

KEP-5073: Declarative Validation of Kubernetes Native Types With validation-gen#5074

Merged
k8s-ci-robot merged 18 commits intokubernetes:masterfrom
aaron-prindle:declarative-validation-with-validation-gen
Feb 13, 2025
Merged

KEP-5073: Declarative Validation of Kubernetes Native Types With validation-gen#5074
k8s-ci-robot merged 18 commits intokubernetes:masterfrom
aaron-prindle:declarative-validation-with-validation-gen

Conversation

@aaron-prindle
Copy link
Copy Markdown
Contributor

One-line PR description: Implement declarative validation of Kubernetes native types using validation-gen to generate validation code.
Issue link: #5073

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot requested review from jpbetz and sttts January 22, 2025 19:33
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 22, 2025
@aaron-prindle aaron-prindle force-pushed the declarative-validation-with-validation-gen branch 3 times, most recently from 73f9dcd to fdcec1b Compare January 22, 2025 19:56
@aaron-prindle aaron-prindle mentioned this pull request Jan 22, 2025
15 tasks
@jpbetz
Copy link
Copy Markdown
Contributor

jpbetz commented Jan 22, 2025

/label lead-opted-in
/milestone v1.33

@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 22, 2025
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 22, 2025
@aaron-prindle aaron-prindle force-pushed the declarative-validation-with-validation-gen branch 2 times, most recently from 996751a to b31c75f Compare January 22, 2025 20:55
@aaron-prindle
Copy link
Copy Markdown
Contributor Author

aaron-prindle commented Jan 22, 2025

/cc @deads2k @liggitt @msau42 @thockin

NOTE: adding @msau42 and @thockin from api-reviewers given a goal of the KEP is to streamline API reviews (not for an API review on the KEP itself)

Comment thread keps/sig-api-machinery/5073-declarative-validation-with-validation-gen/README.md Outdated
@aaron-prindle aaron-prindle force-pushed the declarative-validation-with-validation-gen branch from b31c75f to c1bce5a Compare January 23, 2025 01:13
@aaron-prindle aaron-prindle force-pushed the declarative-validation-with-validation-gen branch 5 times, most recently from ab4fe70 to 68fe8c5 Compare January 23, 2025 22:55
@aaron-prindle aaron-prindle force-pushed the declarative-validation-with-validation-gen branch 6 times, most recently from c37700e to 451a37d Compare February 11, 2025 22:54
Comment thread keps/sig-api-machinery/5073-declarative-validation-with-validation-gen/README.md Outdated
@aaron-prindle aaron-prindle force-pushed the declarative-validation-with-validation-gen branch 7 times, most recently from e120fb9 to 0f7fb65 Compare February 12, 2025 00:54
@aaron-prindle aaron-prindle force-pushed the declarative-validation-with-validation-gen branch from 0f7fb65 to 3492567 Compare February 12, 2025 00:58
Comment thread keps/sig-api-machinery/5073-declarative-validation-with-validation-gen/README.md Outdated
@aaron-prindle aaron-prindle force-pushed the declarative-validation-with-validation-gen branch 3 times, most recently from 5eeff7b to 368dda8 Compare February 12, 2025 19:12
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Feb 13, 2025

/lgtm

/hold

holding for other reviewers, but without a nak I plan to merge tomorrow.

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Feb 13, 2025

/approve
/hold cancel

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaron-prindle, deads2k, jpbetz, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lead-opted-in Denotes that an issue has been opted in to a release lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants