Merged
Conversation
Member
Author
|
#279 に一部対応する。しかし、FTPサーバー側がセッション再利用を要求した場合に、接続に失敗する。Schannelの処理を追っているが現状では解決策が見つかっておらず、制限となる。 |
hwtnb
pushed a commit
to HaijinW/ffftp
that referenced
this pull request
Oct 31, 2022
Socket周りのリファクタリング
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
既存のコードでは生の
SOCKETハンドルを扱っているため、処理の構造化も困難となっていた。ソケットオブジェクトを導入し必要な状態を保持することでリファクタリングを行う。例えば、ソケットの接続先サーバー名を保持する。これにより、Control connectionからData connectionに対して接続先サーバー名を引き継げ、SSLの証明書処理を確実に行えるようになる。
次いで、TLS v1.3対応を行う。具体的には
DecryptMessage()が返すSEC_I_RENEGOTIATEが処理できていなかった。理由は簡単で、ソケットの状態を保持できていなかったから。