[match] fix cache issues in read-only mode#21767
Merged
Merged
Conversation
Contributor
Author
|
@rogerluan , @lacostej, please review. |
Member
|
I'm OOO till next week, but I'll take a look when I'm back :) |
Contributor
Author
Sorry, it's a regression I've introduced by implementing a cache for the match 😭. |
Contributor
Author
|
@joshdholtz , sorry for the ping. Can you please review and release #21767 and #21766 since there is a regression impacting a lot of folks? |
This was referenced Jan 3, 2024
|
For reviewers of this PR - I verified and confirmed that this change fixes the issue for me (#21762 (comment)) |
4 tasks
Contributor
|
I can also confirm that fixes #21762 Good job and thank you! |
4 tasks
This was referenced Jan 4, 2024
SubhrajyotiSen
pushed a commit
to KeepTruckin/fastlane
that referenced
this pull request
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Resolves #21762 .
Description
The cache can be used only when read-only mode is disabled.
Updates for spec_helper and new test structure copypasted from #21691.
Added test for read-only mode.
Looks better w/o spaces diff.
Testing Steps
Run the match action in read-only mode.