Skip to content

[sigh] fix cache parameters validation#21766

Merged
joshdholtz merged 3 commits into
fastlane:masterfrom
nekrich:fix/sigh-cache-parameters-validation
Jan 4, 2024
Merged

[sigh] fix cache parameters validation#21766
joshdholtz merged 3 commits into
fastlane:masterfrom
nekrich:fix/sigh-cache-parameters-validation

Conversation

@nekrich

@nekrich nekrich commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Regression issue comment.

Description

Lift restrictions on cache_* parameters for sigh.

Testing Steps

@nekrich nekrich changed the title fix: sigh cache validation parameters [sigh] fix cache parameters validation Jan 3, 2024
@nekrich nekrich marked this pull request as ready for review January 3, 2024 13:43
@nekrich

nekrich commented Jan 3, 2024

Copy link
Copy Markdown
Contributor Author

@joshdholtz , sorry for the ping. Please review and release #21767 and #21766 since regression impacts many folks?

@joshdholtz joshdholtz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joshdholtz joshdholtz merged commit 5ca4eb7 into fastlane:master Jan 4, 2024
SubhrajyotiSen pushed a commit to KeepTruckin/fastlane that referenced this pull request Jan 17, 2024
* fix: sigh cache validation parameters

* fix: needs_profiles_devices resoling in portal cache

* chore: fix nil devices and certificates
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants