Revert "Re-add typed decorators (#4111)"#4129
Merged
Conversation
Member
Author
|
cc @wyozi I'm happy to land the typed decorators but it should support basic usage of decorators. Something as simple as: Should be supported or pass with minimal changes. As it is right now it seems it's not supported at all. |
This reverts commit 20263a1.
aba2e56 to
3d86b44
Compare
Member
Author
|
@wyozi it would be great if you could make typed decorators a bit less breaking for the ecosystem. |
4 tasks
Member
Author
|
See #4123 (comment) for a longer explanation. The typed decorators needs a bit more work and I'm going to revert them now to cut a release of Fastify. |
voxpelli
added a commit
to voxpelli/fastify
that referenced
this pull request
Jun 26, 2023
Non-breaking backwards compatible enhancement of decorators. Should not have the issues of fastify#4110 which was reverted in fastify#4129
voxpelli
added a commit
to voxpelli/fastify
that referenced
this pull request
Jun 26, 2023
Non-breaking backwards compatible enhancement of decorators. Should not have the issues of fastify#4110 which was reverted in fastify#4129 Signed-off-by: Pelle Wessman <pelle@kodfabrik.se>
3 tasks
mcollina
pushed a commit
that referenced
this pull request
Jun 30, 2023
* feat: have `decorate()` etc enforce typed values Non-breaking backwards compatible enhancement of decorators. Should not have the issues of #4110 which was reverted in #4129 Signed-off-by: Pelle Wessman <pelle@kodfabrik.se> * test: test typed decoration properties * Add support + tests for `getter`/`setter` interface * Use the same definition for all decoration methods --------- Signed-off-by: Pelle Wessman <pelle@kodfabrik.se>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 20263a1.
I don't think we can land this change. Moreover I don't think the change is correct.
After applying that change, I did not find a way to make https://github.com/fastify/fastify-passport/blob/4b912074ad2273172b65eb44e52201e37583226e/src/CreateInitializePlugin.ts#L9-L13 compile.
Checklist
npm run testandnpm run benchmarkand the Code of conduct