Skip to content

Re-add typed decorators#4111

Merged
mcollina merged 2 commits intofastify:mainfrom
wyozi:readd-typed-decorators
Jul 9, 2022
Merged

Re-add typed decorators#4111
mcollina merged 2 commits intofastify:mainfrom
wyozi:readd-typed-decorators

Conversation

@wyozi
Copy link
Contributor

@wyozi wyozi commented Jul 4, 2022

Fixes #4110

Checklist

@Eomm Eomm added the typescript TypeScript related label Jul 4, 2022
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina changed the title Readd typed decorators Re-add typed decorators Jul 4, 2022
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a breaking change since the order of generic is changed

I see the comment on the issue.

@mcollina
Copy link
Member

mcollina commented Jul 5, 2022

@fastify/typescript please chime in

@mcollina mcollina merged commit 20263a1 into fastify:main Jul 9, 2022
mcollina added a commit that referenced this pull request Jul 11, 2022
mcollina added a commit that referenced this pull request Jul 11, 2022
mcollina added a commit that referenced this pull request Jul 12, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

typescript TypeScript related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Figure out what to do with typed decorators

4 participants