workflows:pin node versions to lts #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurgunday
commented
Jul 6, 2024
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
gurgunday
commented
Jul 6, 2024
.github/workflows/ci.yml
Outdated
| uses: fastify/workflows/.github/workflows/plugins-ci.yml@v5.0.0 | ||
| with: | ||
| license-check: true | ||
| node-versions: '["16", "18", "20", "22"]' |
Member
Author
There was a problem hiding this comment.
Should we test on node 16?
Member
There was a problem hiding this comment.
also on v14, I don't think we have shipped a major or this yet.
Member
Author
There was a problem hiding this comment.
We might need tape, will take a look
gurgunday
commented
Jul 6, 2024
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
Fdawgs
approved these changes
Jul 6, 2024
Member
|
Seems like I spoke too early. Let’s cut it at v20+ and cut a major then. |
gurgunday
commented
Jul 6, 2024
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
jsumners
pushed a commit
that referenced
this pull request
Jul 9, 2024
* pin node versions to lts * Update .github/workflows/ci.yml Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> * Update .github/workflows/ci.yml Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> * Update .github/workflows/ci.yml Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> --------- Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
jsumners
added a commit
that referenced
this pull request
Jul 9, 2024
* Update for Fastify v5 (#150) * upgrade for fastify 5 * Fixed typo * removed engine field * workflows:pin node versions to lts (#154) * pin node versions to lts * Update .github/workflows/ci.yml Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> * Update .github/workflows/ci.yml Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> * Update .github/workflows/ci.yml Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> --------- Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> * Update for Fastify v5 (#150) * upgrade for fastify 5 * Fixed typo * removed engine field * workflows:pin node versions to lts (#154) * pin node versions to lts * Update .github/workflows/ci.yml Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> * Update .github/workflows/ci.yml Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> * Update .github/workflows/ci.yml Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> --------- Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> --------- Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> Co-authored-by: Cristian Barlutiu <cristian.barlutiu@gmail.com> Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.