Skip to content

Conversation

@synapse
Copy link
Contributor

@synapse synapse commented Mar 22, 2024

Ref: fastify/fastify#5116

⚠️ There's already a next branch here

Checklist

CC @simoneb

Copy link
Contributor Author

@synapse synapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo

@synapse synapse changed the base branch from next to master March 22, 2024 10:18
Copy link
Contributor Author

@synapse synapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed engine field

@gurgunday gurgunday changed the base branch from master to next March 22, 2024 10:36
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday merged commit fa20420 into fastify:next Mar 22, 2024
jsumners pushed a commit that referenced this pull request Jul 9, 2024
* upgrade for fastify 5

* Fixed typo

* removed engine field
jsumners added a commit that referenced this pull request Jul 9, 2024
* Update for Fastify v5 (#150)

* upgrade for fastify 5

* Fixed typo

* removed engine field

* workflows:pin node versions to lts (#154)

* pin node versions to lts

* Update .github/workflows/ci.yml

Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>

* Update .github/workflows/ci.yml

Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>

* Update .github/workflows/ci.yml

Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>

---------

Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>

* Update for Fastify v5 (#150)

* upgrade for fastify 5

* Fixed typo

* removed engine field

* workflows:pin node versions to lts (#154)

* pin node versions to lts

* Update .github/workflows/ci.yml

Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>

* Update .github/workflows/ci.yml

Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>

* Update .github/workflows/ci.yml

Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>

---------

Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>

---------

Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day>
Co-authored-by: Cristian Barlutiu <cristian.barlutiu@gmail.com>
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants