⬆️ Allow Starlette 0.38.x, update the pin to >=0.37.2,<0.39.0#11876
⬆️ Allow Starlette 0.38.x, update the pin to >=0.37.2,<0.39.0#11876tiangolo merged 3 commits intofastapi:masterfrom
>=0.37.2,<0.39.0#11876Conversation
|
📝 Docs preview for commit a03ad2a at: https://c05c2fad.fastapitiangolo.pages.dev |
|
Any chance this can make it into a patch release? https://github.com/encode/starlette/releases/tag/0.38.2 will silence an annoying Snyk alert that isn't mentioned in the changelog (see Kludex/starlette#2653) |
Wouldn't Snyk continue to complain anyway? 🤔 Or was it because Starlette removed the pin of anyio on the test requirements? |
I didn't add anything that would break FastAPI on 0.38.0 as well, FYI. |
You know, now I'm not sure. I guess I'll find out? |
|
Could this be included in 0.112.1? |
|
+1 0.38.0 included Kludex/starlette#2583 , which is a (non-critical but niggling) issue that's still currently affecting my apps running fastapi / starlette. |
|
📝 Docs preview for commit 4c1c4da at: https://5d07732a.fastapitiangolo.pages.dev |
>=0.37.2,<0.39.0
|
Great, thank you @musicinmybrain and @Kludex! This will be available in FastAPI |
…api#11876) Co-authored-by: svlandeg <svlandeg@github.com> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
I ran the tests (with Starlette 0.38.1) and did not observe any regressions.
https://github.com/encode/starlette/releases/tag/0.38.0
https://github.com/encode/starlette/releases/tag/0.38.1