Skip to content

⬆️ Allow Starlette 0.38.x, update the pin to >=0.37.2,<0.39.0#11876

Merged
tiangolo merged 3 commits intofastapi:masterfrom
musicinmybrain:starlette-0.38
Aug 15, 2024
Merged

⬆️ Allow Starlette 0.38.x, update the pin to >=0.37.2,<0.39.0#11876
tiangolo merged 3 commits intofastapi:masterfrom
musicinmybrain:starlette-0.38

Conversation

@musicinmybrain
Copy link
Copy Markdown
Contributor

I ran the tests (with Starlette 0.38.1) and did not observe any regressions.

https://github.com/encode/starlette/releases/tag/0.38.0

https://github.com/encode/starlette/releases/tag/0.38.1

@tiangolo
Copy link
Copy Markdown
Member

📝 Docs preview for commit a03ad2a at: https://c05c2fad.fastapitiangolo.pages.dev

@alejsdev alejsdev changed the title Allow Starlette 0.38.x ⬆️ Allow Starlette 0.38.x Jul 24, 2024
@voltagex
Copy link
Copy Markdown

Any chance this can make it into a patch release? https://github.com/encode/starlette/releases/tag/0.38.2 will silence an annoying Snyk alert that isn't mentioned in the changelog (see Kludex/starlette#2653)

@Kludex
Copy link
Copy Markdown
Member

Kludex commented Jul 30, 2024

Any chance this can make it into a patch release? encode/starlette@0.38.2 (release) will silence an annoying Snyk alert that isn't mentioned in the changelog (see encode/starlette#2653)

Wouldn't Snyk continue to complain anyway? 🤔 Or was it because Starlette removed the pin of anyio on the test requirements?

@Kludex
Copy link
Copy Markdown
Member

Kludex commented Jul 30, 2024

I ran the tests (with Starlette 0.38.1) and did not observe any regressions.

I didn't add anything that would break FastAPI on 0.38.0 as well, FYI.

@voltagex
Copy link
Copy Markdown

Any chance this can make it into a patch release? encode/starlette@0.38.2 (release) will silence an annoying Snyk alert that isn't mentioned in the changelog (see encode/starlette#2653)

Wouldn't Snyk continue to complain anyway? 🤔 Or was it because Starlette removed the pin of anyio on the test requirements?

You know, now I'm not sure. I guess I'll find out?

@jarey
Copy link
Copy Markdown

jarey commented Aug 7, 2024

Could this be included in 0.112.1?

@Kludex Kludex added the p2 label Aug 7, 2024
@Jaza
Copy link
Copy Markdown

Jaza commented Aug 14, 2024

+1

0.38.0 included Kludex/starlette#2583 , which is a (non-critical but niggling) issue that's still currently affecting my apps running fastapi / starlette.

@github-actions
Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 4c1c4da at: https://5d07732a.fastapitiangolo.pages.dev

@tiangolo tiangolo changed the title ⬆️ Allow Starlette 0.38.x ⬆️ Allow Starlette 0.38.x, update the pin to >=0.37.2,<0.39.0 Aug 15, 2024
@tiangolo tiangolo merged commit 5fd9ab9 into fastapi:master Aug 15, 2024
@tiangolo
Copy link
Copy Markdown
Member

Great, thank you @musicinmybrain and @Kludex! This will be available in FastAPI 0.112.1, released in the next hours. 🚀

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
…api#11876)

Co-authored-by: svlandeg <svlandeg@github.com>
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants