Send 404 instead of 500 when filename requested is too long on StaticFiles#2583
Merged
Kludex merged 4 commits intoKludex:masterfrom Jun 1, 2024
Merged
Send 404 instead of 500 when filename requested is too long on StaticFiles#2583Kludex merged 4 commits intoKludex:masterfrom
StaticFiles#2583Kludex merged 4 commits intoKludex:masterfrom
Conversation
StaticFiles
Contributor
Author
|
Thanks @Kludex ! TIL you can be more specific about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If a static file with a really long name is requested, then it causes an
OSErrorto be raised saying "Filename too long". This error currently gets propagated, resulting in a 500 response. In such a case, the name is too long for the underlying OS to handle, therefore a file with that name couldn't possibly exist, therefore it would be more appropriate to not propagate the error and to return a 404 response.Checklist
Note: I feel that the existing documentation is adequate, it already states: