Android support by cgestes · Pull Request #175 · facebookarchive/draft-js

cgestes · 2016-03-08T02:29:17Z

This fixes some issues for chrome support on Android. (including crosswalk)

use the provided selection in editOnInput
remove former text provided in compositionstart

remaining issues:

moving the selection while composition is active discard the composition
calling restoreEditorDOM() close the keyboard

I believe this can be merged after review without waiting for the other fixes. The experience is already much improved.

cgestes · 2016-03-08T02:29:50Z

src/component/handlers/edit/editOnInput.js

is this ok?

What's the scenario here? For Android text replacement, the span can be the anchor node?

No idea, it just happens. Will check more carefully next time I debug draft-js

Were you able to get more details on this case?

facebook-github-bot · 2016-03-08T02:30:31Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

cgestes · 2016-03-08T02:30:34Z

src/component/handlers/edit/editOnInput.js

I need to find how to check for chrome under Android

facebook-github-bot · 2016-03-08T02:39:41Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

hellendag · 2016-03-14T19:03:41Z

src/component/handlers/composition/DraftEditorCompositionHandler.js

Nit: Combine conditionals.

This fixes an issue on Android. It looks ok for others browser also

hellendag · 2016-04-12T21:42:17Z

Ok, I'm going to import this and do some testing.

hellendag · 2016-04-12T21:42:22Z

@facebook-github-bot import

facebook-github-bot · 2016-04-12T21:51:23Z

Thanks for importing. If you are an FB employee go to Phabricator to review.

sugarshin · 2016-05-24T06:33:33Z

👍

jaaberg · 2016-06-07T05:50:54Z

What's the status on this one, @hellendag? Would be nice to improve the Android support.

hellendag · 2016-06-15T21:57:06Z

Patching and testing.

hellendag · 2016-06-15T23:27:52Z

src/component/handlers/edit/editOnInput.js


 var isGecko = UserAgent.isEngine('Gecko');
-
+var isAndroid = UserAgent.isPlatform('Android');


Can we be more specific about targeting browser engines? Or does this need to apply across Android?

butchmarshall · 2016-07-28T22:30:41Z

calling restoreEditorDOM() close the keyboard

It looks like calling restoreEditorDOM setState changes the active element from the div -> body -> div rapidly. This causes the keyboard to close.

Saw this by monitoring the documents focusin/focusout events.

It looks like it closes in react.js right after .$editor0 node is removed.

Open at this point

next step it closes

React removes the entire <div class="DraftEditor-editorContainer"> element when updating via setState. This obviously removes the child contenteditable="true" which had the focus keeping the keyboard open. This would definitely make it loose focus.

This is caused by... {containerKey: this.state.containerKey + 1}

Which it looks like is used to force a complete re-render.

@hellendag - moving key: 'editor' + this.state.containerKey, from the ref: 'editorContainer' to the data-contents="true" element in DraftEditor.prototype.render fixes this. I don't know enough to know what the side-effects be though?

Why force the re-render of everything, and not just the data-contents?

I've created a pull request #572 to illustrate the changes.

dannyshisler · 2016-08-05T23:26:04Z

Is there any update on this? I could really do with this Android keyboard issue being resolved. Thanks

andyesp · 2016-08-25T17:06:24Z

What is the status on this? Do you need help testing?

walter0331 · 2016-09-01T08:26:53Z

Hi, I also have some text composition issues on iOS devices, are these issues related?#626

jan4984 · 2016-09-21T04:14:02Z

for adding myself to participants

StevenLangbroek · 2016-10-04T09:28:49Z

@hellendag @cgestes is there any word on when this might land? it's blocking us from implementing Draft in our codebase.

pklingem · 2016-10-19T17:12:40Z

We're also waiting anxiously for this, commenting for notifications, apologies for noise.

kevinmartin · 2016-10-19T20:46:50Z

@pklingem If you want notifications without giving everyone "noise", you could just press the Subscribe button on the right sidebar of any issue...

pklingem · 2016-10-19T21:26:22Z

thanks @kevinmartin I just clicked subscribe.

jan4984 · 2016-11-02T01:52:26Z

please some one merge this PR?

kenjiru · 2016-11-26T23:32:35Z

I've ran into this issue when porting my app to Cordova. I was a bit surprised to discover that draft doesn't support Android. Now this issue is the only thing blocking us from releasing our app.

mitermayer · 2016-12-15T21:40:22Z

Hi @cgestes , it looks like this pull request has been abandoned, so I am going to close it. If someone is still interested in working on this please feel free to reopen it!

Based off facebookarchive#175, this commit fixes some issues with autocomplete behavior on Android Chrome.

cgestes reviewed Mar 8, 2016
View reviewed changes

src/component/handlers/edit/editOnInput.js Outdated

Copy link

Contributor Author

cgestes Mar 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to find how to check for chrome under Android

facebook-github-bot added the CLA Signed label Mar 8, 2016

cgestes mentioned this pull request Mar 8, 2016

Broken on Android mobile web #102

Closed

cgestes force-pushed the android-support branch from 7b9a446 to 4fdc94a Compare March 8, 2016 13:58

cgestes changed the title ~~WIP: Android support~~ Android support Mar 8, 2016

hellendag reviewed Mar 14, 2016
View reviewed changes

src/component/handlers/composition/DraftEditorCompositionHandler.js Outdated

Copy link

hellendag Mar 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Combine conditionals.

cgestes added 2 commits March 15, 2016 13:21

editOnInput: Android support

5991cec

Composition: remove former text when provided in compositionstart

d6bb473

This fixes an issue on Android. It looks ok for others browser also

cgestes force-pushed the android-support branch from 4fdc94a to d6bb473 Compare March 15, 2016 11:21

hellendag added the PR imported label Apr 12, 2016

hellendag reviewed Jun 15, 2016
View reviewed changes

ghost added the CLA Signed label Jul 12, 2016

ghost added the CLA Signed label Jul 29, 2016

jan4984 mentioned this pull request Sep 21, 2016

typing text to draft-js editor with "Google Keyboard" in android #673

Closed

facebook-github-bot added the CLA Signed label Oct 4, 2016

oosthoek added a commit to oosthoek/draft-js that referenced this pull request Oct 10, 2016

android support from PR facebookarchive#175

5ca8a54

facebook-github-bot added the CLA Signed label Oct 10, 2016

facebook-github-bot added the CLA Signed label Oct 21, 2016

robbertbrak added a commit to robbertbrak/draft-js that referenced this pull request Nov 28, 2016

Apply facebookarchive#175

f63f1d5

mitermayer closed this Dec 15, 2016

robbertbrak mentioned this pull request Dec 28, 2016

Editor lost focus after first word (space bar is pressed) on Android browser. #888

Closed

AndrewSouthpaw added a commit to AndrewSouthpaw/draft-js that referenced this pull request Feb 16, 2017

Fix autocomplete behavior for Android chrome.

c365cfa

Based off facebookarchive#175, this commit fixes some issues with autocomplete behavior on Android Chrome.

AndrewSouthpaw mentioned this pull request Feb 16, 2017

Fix autocomplete behavior for Android chrome. #1013

Open


		var isGecko = UserAgent.isEngine('Gecko');

		var isAndroid = UserAgent.isPlatform('Android');

Conversation

cgestes commented Mar 8, 2016

Uh oh!

cgestes Mar 8, 2016

Choose a reason for hiding this comment

Uh oh!

hellendag Mar 14, 2016

Choose a reason for hiding this comment

Uh oh!

cgestes Mar 15, 2016

Choose a reason for hiding this comment

Uh oh!

hellendag Mar 31, 2016

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Mar 8, 2016

Uh oh!

cgestes Mar 8, 2016

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Mar 8, 2016

Uh oh!

hellendag Mar 14, 2016

Choose a reason for hiding this comment

Uh oh!

hellendag commented Apr 12, 2016

Uh oh!

hellendag commented Apr 12, 2016

Uh oh!

facebook-github-bot commented Apr 12, 2016

Uh oh!

sugarshin commented May 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaaberg commented Jun 7, 2016

Uh oh!

hellendag commented Jun 15, 2016

Uh oh!

hellendag Jun 15, 2016

Choose a reason for hiding this comment

Uh oh!

butchmarshall commented Jul 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dannyshisler commented Aug 5, 2016

Uh oh!

andyesp commented Aug 25, 2016

Uh oh!

walter0331 commented Sep 1, 2016

Uh oh!

jan4984 commented Sep 21, 2016

Uh oh!

StevenLangbroek commented Oct 4, 2016

Uh oh!

pklingem commented Oct 19, 2016

Uh oh!

kevinmartin commented Oct 19, 2016

Uh oh!

pklingem commented Oct 19, 2016

Uh oh!

jan4984 commented Nov 2, 2016

Uh oh!

kenjiru commented Nov 26, 2016

Uh oh!

mitermayer commented Dec 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

sugarshin commented May 24, 2016 •

edited

Loading

butchmarshall commented Jul 28, 2016 •

edited

Loading