Android will loose focus if the contenteditable field is redrawn. This forces keyboard close.#572
Conversation
|
Hm. I'm worried that there could be other children of the contenteditable div in the DOM that wouldn't get removed if we only rekey the contents component. |
|
I was wondering if there were any children not in the content="true" element @spicyj - thanks for the clarification. Would a more targeted updating method work? Right now I'm thinking:
|
4bb7dab to
f18c84e
Compare
…cing the keyboard to close
f18c84e to
e1e600e
Compare
|
Is there any chance of this getting merged sometime soon? |
|
Hey @codejet, the concern here is we're not sure if this is the proper fix. It fixes the keyboard issue, but because of the more targeted redraw we need to make sure it doesn't cause any other issues. |
|
I don't think there should be any other children of the I'm actually wondering if it would always be safe to redraw only the
The case where I can see problems occurring is where a cut or composition discards the entire Would you mind giving this a try and going through the cut/composition parts of the manual test plan to see if it works? |
|
It seems like select all then cut would delete the contents completely… |
|
Dear god, please merge this |
|
FYI Googlers: I was able to sidestep this problem by by disabling autocorrect on the contentdeditable element on Android. |
|
@hellendag Your suggestion about only redrawing |
|
May want to also check out #907, looks like it tackles the same issue with a similar fix. |
|
We ended up merging a similar PR - #907 so closing this. |
Also replace patch facebookarchive#572 in favor of facebookarchive#907
Android will loose focus if the contenteditable="true" field is also redrawn.
This restricts forcing redraw to the only the element instead of redrawing the contenteditable="true" element.