Fix a compilation error in CircleCI vs2019 CXX20#8090
Closed
riversand963 wants to merge 1 commit intofacebook:masterfrom
Closed
Fix a compilation error in CircleCI vs2019 CXX20#8090riversand963 wants to merge 1 commit intofacebook:masterfrom
riversand963 wants to merge 1 commit intofacebook:masterfrom
Conversation
4b572bb to
f9715c8
Compare
Contributor
|
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ltamasi
approved these changes
Mar 23, 2021
Contributor
|
Turns out we actually have an open issue for this (#7625) that we could close once this lands. |
Contributor
|
@riversand963 merged this pull request in 2a12b80. |
rzarzynski
pushed a commit
to ceph/rocksdb
that referenced
this pull request
Sep 29, 2022
Summary: As title. Always specify namespace::symbol_name... Test plan CircleCI and other CI results Pull Request resolved: facebook#8090 Reviewed By: ltamasi Differential Revision: D27256130 Pulled By: riversand963 fbshipit-source-id: b9b9ae2b3a8b4a16f0384292e71c6aecca93c570
rzarzynski
added a commit
to ceph/rocksdb
that referenced
this pull request
Sep 29, 2022
Fix a compilation error in CircleCI vs2019 CXX20 (facebook#8090) Reviewed-by: Laura Flores <lflores@redhat.com> Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title.
Always specify namespace::symbol_name...
Test plan
CircleCI and other CI results