Fix a compilation error in CircleCI vs2019 CXX20 (#8090)#43
Merged
rzarzynski merged 1 commit intoceph:ceph-quincy-v6.15.5-1from Sep 29, 2022
Merged
Conversation
Summary: As title. Always specify namespace::symbol_name... Test plan CircleCI and other CI results Pull Request resolved: facebook#8090 Reviewed By: ltamasi Differential Revision: D27256130 Pulled By: riversand963 fbshipit-source-id: b9b9ae2b3a8b4a16f0384292e71c6aecca93c570
14 tasks
ljflores
approved these changes
Sep 22, 2022
rzarzynski
approved these changes
Sep 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be able to compile rocksdb with c++20 on Ubuntu to avoid
free(): invalid pointerwith librados tests.The compilation (with c++20) causes the following error:
https://pulpito.ceph.com/matan-2022-09-22_07:51:28-rados:singleton-main-distro-default-smithi/
which was fixed here: facebook#8090
Fixes: https://tracker.ceph.com/issues/57632
(cherry picked from commit 2a12b80)
Signed-off-by: Matan Breizman mbreizma@redhat.com