Skip to content

Reapply fix for https://github.com/facebook/rocksdb/issues/13166#13265

Closed
vaqxai wants to merge 1 commit intofacebook:mainfrom
vaqxai:patch-1
Closed

Reapply fix for https://github.com/facebook/rocksdb/issues/13166#13265
vaqxai wants to merge 1 commit intofacebook:mainfrom
vaqxai:patch-1

Conversation

@vaqxai
Copy link
Contributor

@vaqxai vaqxai commented Jan 2, 2025

There was a fix in #13171 for issue #13166 but it was overwritten by commit d5345a8. This PR is to reapply the fix.

Fixes #13264 to have Rocks compile under Ubuntu again

@facebook-github-bot
Copy link
Contributor

Hi @vaqxai!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@cbi42 merged this pull request in 62a7ddb.

ybtsdst pushed a commit to ybtsdst/rocksdb that referenced this pull request Apr 27, 2025
Summary:
There was a fix in facebook#13171 for issue facebook#13166 but it was overwritten by commit facebook@d5345a8. This PR is to reapply the fix.

Fixes facebook#13264 to have Rocks compile under Ubuntu again

Pull Request resolved: facebook#13265

Reviewed By: archang19

Differential Revision: D67764706

Pulled By: cbi42

fbshipit-source-id: c8822fff6769bf3be1e6ceee3f2b58b09d8569b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build fails on Ubuntu

3 participants