Small fix in WBWIMemtable::UpdateKey()#13171
Closed
cbi42 wants to merge 1 commit intofacebook:mainfrom
Closed
Conversation
ltamasi
approved these changes
Nov 30, 2024
Contributor
|
@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
This was referenced Jan 2, 2025
Closed
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 2, 2025
Summary: There was a fix in #13171 for issue #13166 but it was overwritten by commit d5345a8. This PR is to reapply the fix. Fixes #13264 to have Rocks compile under Ubuntu again Pull Request resolved: #13265 Reviewed By: archang19 Differential Revision: D67764706 Pulled By: cbi42 fbshipit-source-id: c8822fff6769bf3be1e6ceee3f2b58b09d8569b3
ybtsdst
pushed a commit
to ybtsdst/rocksdb
that referenced
this pull request
Apr 27, 2025
Summary: fixes issue facebook#13166. Pull Request resolved: facebook#13171 Test Plan: the same command in facebook#13166 doesn't reproduce for me. Reviewed By: ltamasi Differential Revision: D66621871 Pulled By: cbi42 fbshipit-source-id: 08820a22071091606b437181e2b5e9343202d637
ybtsdst
pushed a commit
to ybtsdst/rocksdb
that referenced
this pull request
Apr 27, 2025
Summary: There was a fix in facebook#13171 for issue facebook#13166 but it was overwritten by commit facebook@d5345a8. This PR is to reapply the fix. Fixes facebook#13264 to have Rocks compile under Ubuntu again Pull Request resolved: facebook#13265 Reviewed By: archang19 Differential Revision: D67764706 Pulled By: cbi42 fbshipit-source-id: c8822fff6769bf3be1e6ceee3f2b58b09d8569b3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: fixes issue #13166.
Test plan: the same command in #13166 doesn't reproduce for me.