DatePickerIOS - Added Snack Examples 🍿#1583
Conversation
|
Deploy preview for react-native ready! Built with commit f882480 https://deploy-preview-1583--react-native.netlify.com Changes to Thank you for your contributions. |
nearestnabors
left a comment
There was a problem hiding this comment.
Thanks for committing this!
Added `&supportedPlatforms=ios` config to Snack player and removed platform checking code
|
I'm not sure if adding an example for the the deprecated component is a good idea. They will be sooner or later completely removed form the codebase and not providing examples for them could be a good way to discourage usage of those components. |
@Simek I'll leave the decision to the maintainers 👍 |
|
It seems that Rachel got similar concerns to my: #1579 (comment) @rachelnabors Also after thinking about this a bit more I would like to start discussion about removing all examples from the deprecated components after #1493 will be merged and before next major version (0.61 docs and below will remain untouched). |
Actually we want to remove all the deprecated components from the sidebar for 0.62. Want to do it for me? |
|
Keep in mind #1045 while removing pages - if people have bookmarks or page ranked search results we should guide them to the new location for awhile. |
|
@rickhanlonii I think that @rachelnabors want only to remove entries for the deprecated components from the Sidebar and leave pages intact under versioned @rachelnabors I can help with that, no problem. It should help if you describe exactly what is desirable effect of that change. Currently I'm assuming that you want me to generate versioned docs for |
* DatePickerIOS - Added Snack Examples * Update datepickerios.md Added `&supportedPlatforms=ios` config to Snack player and removed platform checking code * removed unused import statements Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>
|
@rickhanlonii So @Simek has me right here—would be great to just remove the links from the sidebar from 62 onward. Editing only sidebars.json should change this in /docs/next/ and all versions going forward—which is what we want! I'd submit a PR for that very thing, @Simek :) |
|
Yup that works. |
* DatePickerIOS - Added Snack Examples * Update datepickerios.md Added `&supportedPlatforms=ios` config to Snack player and removed platform checking code * removed unused import statements Co-authored-by: Rachel Nabors <rachelnabors@users.noreply.github.com>
Belongs to #1579
Created a nice little snack for people to view DatePickerIOS in action using both Function & Class Component examples.