Skip to content

deprecation indicator and deprecation notes standardization#1493

Merged
nearestnabors merged 3 commits intofacebook:masterfrom
Simek:deprecation-standardization
Feb 7, 2020
Merged

deprecation indicator and deprecation notes standardization#1493
nearestnabors merged 3 commits intofacebook:masterfrom
Simek:deprecation-standardization

Conversation

@Simek
Copy link
Copy Markdown
Collaborator

@Simek Simek commented Dec 3, 2019 •
edited
Loading

By deprecation notes standardization I have meant following changes:

  • using current NPM package name
  • using similar phrasing
  • positioning deprecation note always on the top of the page

The rest of changes are basically a concept, which you might not like.

I was aiming to clarify deprecation and discourage developers to use those parts of RN so I have added 🚧emoji to the title of pages marked as deprecated Component or API. (Of course I'm open to change selected emoji, this could be anything else.)

Screenshot 2019-12-03 at 14 59 41

I can work further on this PR or on any other solution that help in the case mentioned above.

@react-native-bot
Copy link
Copy Markdown

react-native-bot commented Dec 3, 2019 •
edited
Loading

Deploy preview for react-native ready!

Built with commit 182d799

https://deploy-preview-1493--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to Contribute • Documentation Sources

@react-native-bot
Copy link
Copy Markdown

react-native-bot commented Dec 3, 2019

Deploy preview for react-native ready!

Built with commit 9269e76

https://deploy-preview-1493--react-native.netlify.com

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to Contribute • Documentation Sources

@nearestnabors nearestnabors added the Design For things that change the design, CSS, layout, etc of the site. Needs testing in multiple browsers label Dec 3, 2019
@nearestnabors nearestnabors self-assigned this Dec 3, 2019
@Simek Simek mentioned this pull request Dec 9, 2019
Closed
@Simek
Copy link
Copy Markdown
Collaborator Author

Simek commented Dec 9, 2019 •
edited
Loading

@rachelnabors I can extract deprecation standardization changes to separate PR if this helps merge them sooner than indicator proposal.

@Simek
Copy link
Copy Markdown
Collaborator Author

Simek commented Dec 11, 2019

@hramos I can't request PR review but maybe you will have any feedback for me?

@nearestnabors
Copy link
Copy Markdown
Contributor

nearestnabors commented Feb 5, 2020

Hi hi! Thanks for working on this. I love it! Can you do ProgressViewIOS and ProgressBarAndroid as well?

@Simek
Copy link
Copy Markdown
Collaborator Author

Simek commented Feb 6, 2020 •
edited
Loading

@rachelnabors I have updated both pages. Hope I have used the right community repos for those components.

@Simek Simek mentioned this pull request Feb 7, 2020
Merged
@nearestnabors nearestnabors merged commit 1f09829 into facebook:master Feb 7, 2020
@Simek Simek mentioned this pull request Feb 7, 2020
Closed
espipj pushed a commit to espipj/react-native-website that referenced this pull request Feb 8, 2020
@Simek @espipj
deprecation indicator and deprecation notes standardization (facebook…
cb50bb3 
…#1493)

* deprecation indicator and deprecation notes standardization

* update few more pages

* update ProgressBarAndroid and ProgressViewIOS
kaioduarte pushed a commit to kaioduarte/react-native-website that referenced this pull request Feb 24, 2020
@Simek @kaioduarte
deprecation indicator and deprecation notes standardization (facebook…
3bf91f4 
…#1493)

* deprecation indicator and deprecation notes standardization

* update few more pages

* update ProgressBarAndroid and ProgressViewIOS
@Simek Simek deleted the deprecation-standardization branch January 26, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nearestnabors nearestnabors

Labels

Design For things that change the design, CSS, layout, etc of the site. Needs testing in multiple browsers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Simek @react-native-bot @nearestnabors