Skip to content

Update podspecs for latest Fabric changes#28584

Closed
empyrical wants to merge 3 commits intofacebook:masterfrom
empyrical:fabric-podfile-tweaks
Closed

Update podspecs for latest Fabric changes#28584
empyrical wants to merge 3 commits intofacebook:masterfrom
empyrical:fabric-podfile-tweaks

Conversation

@empyrical
Copy link
Copy Markdown
Contributor

@empyrical empyrical commented Apr 10, 2020 •
edited
Loading

Summary

This pull request updates the Podspecs to reflect recent changes to Fabric, so they build with Fabric enabled again.

In React-Fabric.podspec, subspecs for the views legacyviewmanagerinterop, safeareaview, textinput, and unimplementedview are added. A minor tweak to the subspec for rncore was added blacklisting two codegen-generated files that have issues building, but are not actually needed yet and are empty.

In React-graphics.podspec, the header paths for Boost were added.

This is partially a retread of #26805, which had to be backed out due to issues with the changes to the Yoga podspec.

Changelog

[Internal] [Fixed] - Fixed building Fabric with the Cocoapods

Test Plan

RNTester can now compile.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Apr 10, 2020
@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Apr 10, 2020 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,607,162 -136,410
android hermes armeabi-v7a 6,283,825 -107,090
android hermes x86 6,947,939 -177,405
android hermes x86_64 6,878,598 -138,006
android jsc arm64-v8a 8,915,985 -727
android jsc armeabi-v7a 8,555,967 -477
android jsc x86 8,740,763 -824
android jsc x86_64 9,317,675 -818

Base commit: 4305a29

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Apr 10, 2020 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal 10,904,704 10,084,400

Base commit: 4305a29

facebook-github-bot
facebook-github-bot reviewed Apr 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@hramos
Copy link
Copy Markdown
Contributor

hramos commented Apr 14, 2020

It looks like the test_ios_detox_frameworks and test_ios_unit_frameworks failures on Circle CI are legit (we fixed these in master last week). To reproduce locally:

cd react-native
yarn
(cd RNTester && USE_FRAMEWORKS=1 pod install)
yarn test-ios

Output:

Testing failed:
	'boost/static_assert.hpp' file not found
	'memory' file not found
	'functional' file not found
	'cassert' file not found
	Could not build module 'jsireact'
	'iosfwd' file not found
	Could not build module 'React'
	Could not build module 'React'
	Testing cancelled because the build failed.

** TEST FAILED **


The following build commands failed:
	CompileC /Users/hramos/Library/Developer/Xcode/DerivedData/RNTesterPods-bgablzpmrtdrulbrsgmoybpwucma/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/React-RCTAnimation.build/Objects-normal/x86_64/RCTAnimationUtils.o /Users/hramos/fbsource/xplat/js/react-native-github/Libraries/NativeAnimation/RCTAnimationUtils.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler

@empyrical
Copy link
Copy Markdown
Contributor Author

empyrical commented Apr 14, 2020

Thanks, I'll take a look at that

@empyrical
Copy link
Copy Markdown
Contributor Author

empyrical commented Apr 14, 2020

Instead of removing those headers from private_header_files , I added "$(PODS_ROOT)/Headers/Private/React-Core" to legacyviewmanagerinterop's header search paths - this is how it appears other specs are getting to these headers already. All tests now pass.

facebook-github-bot
facebook-github-bot reviewed Apr 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Copy Markdown
Collaborator

react-native-bot commented Jun 12, 2020

This pull request was successfully merged by @empyrical in fb2a776.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 12, 2020
ftanuma pushed a commit to ftanuma/react-native that referenced this pull request Jul 11, 2020
@empyrical @ftanuma
Update podspecs for latest Fabric changes (facebook#28584)
2f70706 
Summary:
This pull request updates the Podspecs to reflect recent changes to Fabric, so they build with Fabric enabled again.

In `React-Fabric.podspec`, subspecs for the views `legacyviewmanagerinterop`, `safeareaview`, `textinput`, and `unimplementedview` are added. A minor tweak to the subspec for `rncore` was added blacklisting two codegen-generated files that have issues building, but are not actually needed yet and are empty.

In `React-graphics.podspec`, the header paths for Boost were added.

This is partially a retread of facebook#26805, which had to be backed out due to issues with the changes to the Yoga podspec.

## Changelog

[Internal] [Fixed] - Fixed building Fabric with the Cocoapods
Pull Request resolved: facebook#28584

Test Plan: RNTester can now compile.

Reviewed By: shergin

Differential Revision: D20966065

Pulled By: hramos

fbshipit-source-id: 73931be63b72fcb52705643f81c0f787e571eb76
(cherry picked from commit fb2a776)
ftanuma pushed a commit to ftanuma/react-native that referenced this pull request Oct 5, 2020
@empyrical @ftanuma
Update podspecs for latest Fabric changes (facebook#28584)
05271af 
Summary:
This pull request updates the Podspecs to reflect recent changes to Fabric, so they build with Fabric enabled again.

In `React-Fabric.podspec`, subspecs for the views `legacyviewmanagerinterop`, `safeareaview`, `textinput`, and `unimplementedview` are added. A minor tweak to the subspec for `rncore` was added blacklisting two codegen-generated files that have issues building, but are not actually needed yet and are empty.

In `React-graphics.podspec`, the header paths for Boost were added.

This is partially a retread of facebook#26805, which had to be backed out due to issues with the changes to the Yoga podspec.

## Changelog

[Internal] [Fixed] - Fixed building Fabric with the Cocoapods
Pull Request resolved: facebook#28584

Test Plan: RNTester can now compile.

Reviewed By: shergin

Differential Revision: D20966065

Pulled By: hramos

fbshipit-source-id: 73931be63b72fcb52705643f81c0f787e571eb76
(cherry picked from commit fb2a776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@hramos hramos hramos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@empyrical @analysis-bot @hramos @react-native-bot @facebook-github-bot