[iOS] Fixes Fabric related podspec#26805
Closed
zhongwuzw wants to merge 1 commit intofacebook:masterfrom
Closed
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @zhongwuzw in 4203d24. When will my fix make it into a release? | Upcoming Releases |
Contributor
|
@zhongwuzw, this PR introduces a problem: If you try to build RNTester, it'll fail. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 12, 2020
Summary: This pull request updates the Podspecs to reflect recent changes to Fabric, so they build with Fabric enabled again. In `React-Fabric.podspec`, subspecs for the views `legacyviewmanagerinterop`, `safeareaview`, `textinput`, and `unimplementedview` are added. A minor tweak to the subspec for `rncore` was added blacklisting two codegen-generated files that have issues building, but are not actually needed yet and are empty. In `React-graphics.podspec`, the header paths for Boost were added. This is partially a retread of #26805, which had to be backed out due to issues with the changes to the Yoga podspec. ## Changelog [Internal] [Fixed] - Fixed building Fabric with the Cocoapods Pull Request resolved: #28584 Test Plan: RNTester can now compile. Reviewed By: shergin Differential Revision: D20966065 Pulled By: hramos fbshipit-source-id: 73931be63b72fcb52705643f81c0f787e571eb76
ftanuma
pushed a commit
to ftanuma/react-native
that referenced
this pull request
Jul 11, 2020
Summary: This pull request updates the Podspecs to reflect recent changes to Fabric, so they build with Fabric enabled again. In `React-Fabric.podspec`, subspecs for the views `legacyviewmanagerinterop`, `safeareaview`, `textinput`, and `unimplementedview` are added. A minor tweak to the subspec for `rncore` was added blacklisting two codegen-generated files that have issues building, but are not actually needed yet and are empty. In `React-graphics.podspec`, the header paths for Boost were added. This is partially a retread of facebook#26805, which had to be backed out due to issues with the changes to the Yoga podspec. ## Changelog [Internal] [Fixed] - Fixed building Fabric with the Cocoapods Pull Request resolved: facebook#28584 Test Plan: RNTester can now compile. Reviewed By: shergin Differential Revision: D20966065 Pulled By: hramos fbshipit-source-id: 73931be63b72fcb52705643f81c0f787e571eb76 (cherry picked from commit fb2a776)
ftanuma
pushed a commit
to ftanuma/react-native
that referenced
this pull request
Oct 5, 2020
Summary: This pull request updates the Podspecs to reflect recent changes to Fabric, so they build with Fabric enabled again. In `React-Fabric.podspec`, subspecs for the views `legacyviewmanagerinterop`, `safeareaview`, `textinput`, and `unimplementedview` are added. A minor tweak to the subspec for `rncore` was added blacklisting two codegen-generated files that have issues building, but are not actually needed yet and are empty. In `React-graphics.podspec`, the header paths for Boost were added. This is partially a retread of facebook#26805, which had to be backed out due to issues with the changes to the Yoga podspec. ## Changelog [Internal] [Fixed] - Fixed building Fabric with the Cocoapods Pull Request resolved: facebook#28584 Test Plan: RNTester can now compile. Reviewed By: shergin Differential Revision: D20966065 Pulled By: hramos fbshipit-source-id: 73931be63b72fcb52705643f81c0f787e571eb76 (cherry picked from commit fb2a776)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
safeareaviewandlegacyviewmanagerinterop.YGNode,YGStyle.hto public, fabric uses it, ex.YogaStylableProps.h.React-Core's Cxx header public, becauseRCTLegacyViewManagerInteropCoordinator.muses it.Changelog
[iOS] [Fixed] - Fixes Fabric related podspec
Test Plan
Fabric RNTester can run.