[lexical-playground] Bug Fix: Preserve row striping in frozen table columns#7572
Merged
ivailop7 merged 3 commits intofacebook:mainfrom May 27, 2025
Merged
Conversation
- Fix issue where freezing a column would remove row striping - Maintain proper background colors for odd/even rows in frozen columns - Preserve sticky positioning and border styling Fixes facebook#7571
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
etrepum
reviewed
May 27, 2025
| border-bottom: 1px solid #bbb; | ||
| } | ||
| .PlaygroundEditorTheme__tableFrozenColumn tr > td:first-child { | ||
| .PlaygroundEditorTheme__tableFrozenColumn tr:nth-child(odd) > td:first-child { |
Collaborator
There was a problem hiding this comment.
Probably makes more sense to leave this as the original selector and separately target the even rows when row striping is enabled to only override the background color
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion! I've updated the code to keep the original selector for frozen columns and handle the row striping with frozen column separately. 20c7dbc
- Maintain proper striping behavior for both regular and frozen columns
ivailop7
approved these changes
May 27, 2025
fantactuka
pushed a commit
that referenced
this pull request
Aug 11, 2025
23 tasks
GermanJablo
added a commit
to payloadcms/payload
that referenced
this pull request
Sep 3, 2025
Fixes #13386 Below I write a clarification to copy and paste into the release note, based on our latest upgrade of Lexical [in v3.29.0](https://github.com/payloadcms/payload/releases/tag/v3.29.0). ## Important This release upgrades the lexical dependency from 0.28.0 to 0.34.0. If you installed lexical manually, update it to 0.34.0. Installing lexical manually is not recommended, as it may break between updates, and our re-exported versions should be used. See the [yellow banner box](https://payloadcms.com/docs/rich-text/custom-features) for details. If you still encounter richtext-lexical errors, do the following, in this order: - Delete node_modules - Delete your lockfile (e.g. pnpm-lock.json) - Reinstall your dependencies (e.g. pnpm install) ### Lexical Breaking Changes The following Lexical releases describe breaking changes. We recommend reading them if you're using Lexical APIs directly (`@payloadcms/richtext-lexical/lexical/*`). - [v.0.33.0](https://github.com/facebook/lexical/releases/tag/v0.33.0) - [v.0.30.0](https://github.com/facebook/lexical/releases/tag/v0.30.0) - [v.0.29.0](https://github.com/facebook/lexical/releases/tag/v0.29.0) ___ TODO: - [x] facebook/lexical#7719 - [x] facebook/lexical#7362 - [x] facebook/lexical#7707 - [x] facebook/lexical#7388 - [x] facebook/lexical#7357 - [x] facebook/lexical#7352 - [x] facebook/lexical#7472 - [x] facebook/lexical#7556 - [x] facebook/lexical#7417 - [x] facebook/lexical#1036 - [x] facebook/lexical#7509 - [x] facebook/lexical#7693 - [x] facebook/lexical#7408 - [x] facebook/lexical#7450 - [x] facebook/lexical#7415 - [x] facebook/lexical#7368 - [x] facebook/lexical#7372 - [x] facebook/lexical#7572 - [x] facebook/lexical#7558 - [x] facebook/lexical#7613 - [x] facebook/lexical#7405 - [x] facebook/lexical#7420 - [x] facebook/lexical#7662 --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1211202581885926
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when a table column is frozen using the "Freeze First Column" option, the row striping (alternating row background colors) disappears for the frozen column. This happens because the frozen column cells have a hardcoded white background that overrides the row striping styles.
This PR fixes the issue by:
Closes #7571
Test plan
Before
After
lexical-fix.mov
Additional tests done: