Skip to content

[lexical-playground] Bug: clear formatting should also clear any indent/outdent if applied#7417

Merged
etrepum merged 3 commits intofacebook:mainfrom
harshmetkel24:indent-clear-formatting
Apr 2, 2025
Merged

[lexical-playground] Bug: clear formatting should also clear any indent/outdent if applied#7417
etrepum merged 3 commits intofacebook:mainfrom
harshmetkel24:indent-clear-formatting

Conversation

@harshmetkel24
Copy link
Copy Markdown
Contributor

Description

Steps To Reproduce

  1. Add any text
  2. Select added text and try indent/outdent selected text
  3. Now while keeping selection try clear-formatting it won't have any effect

Before

Screen.Recording.2025-04-02.at.1.37.32.PM.mov

After

Screen.Recording.2025-04-02.at.4.37.13.PM.mov

Impact of fix

clear formatting will be improved and cover wider range

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 1:12pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 1:12pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 2, 2025
@lilshady
Copy link
Copy Markdown
Contributor

lilshady commented Apr 2, 2025

Thanks for making this change. LGMT, the behavior is also aligned with other editor, like google docs.

@etrepum etrepum added this pull request to the merge queue Apr 2, 2025
Merged via the queue into facebook:main with commit 83205d8 Apr 2, 2025
39 checks passed
@etrepum etrepum mentioned this pull request Apr 7, 2025
fantactuka pushed a commit that referenced this pull request Aug 11, 2025
GermanJablo added a commit to payloadcms/payload that referenced this pull request Sep 3, 2025
Fixes #13386

Below I write a clarification to copy and paste into the release note,
based on our latest upgrade of Lexical [in
v3.29.0](https://github.com/payloadcms/payload/releases/tag/v3.29.0).

## Important
This release upgrades the lexical dependency from 0.28.0 to 0.34.0.

If you installed lexical manually, update it to 0.34.0. Installing
lexical manually is not recommended, as it may break between updates,
and our re-exported versions should be used. See the [yellow banner
box](https://payloadcms.com/docs/rich-text/custom-features) for details.

If you still encounter richtext-lexical errors, do the following, in
this order:

- Delete node_modules
- Delete your lockfile (e.g. pnpm-lock.json)
- Reinstall your dependencies (e.g. pnpm install)

### Lexical Breaking Changes

The following Lexical releases describe breaking changes. We recommend
reading them if you're using Lexical APIs directly
(`@payloadcms/richtext-lexical/lexical/*`).

- [v.0.33.0](https://github.com/facebook/lexical/releases/tag/v0.33.0)
- [v.0.30.0](https://github.com/facebook/lexical/releases/tag/v0.30.0)
- [v.0.29.0](https://github.com/facebook/lexical/releases/tag/v0.29.0)

___

TODO:
- [x] facebook/lexical#7719
- [x] facebook/lexical#7362
- [x] facebook/lexical#7707
- [x] facebook/lexical#7388
- [x] facebook/lexical#7357
- [x] facebook/lexical#7352
- [x] facebook/lexical#7472
- [x] facebook/lexical#7556
- [x] facebook/lexical#7417
- [x] facebook/lexical#1036
- [x] facebook/lexical#7509
- [x] facebook/lexical#7693
- [x] facebook/lexical#7408
- [x] facebook/lexical#7450
- [x] facebook/lexical#7415
- [x] facebook/lexical#7368
- [x] facebook/lexical#7372
- [x] facebook/lexical#7572
- [x] facebook/lexical#7558
- [x] facebook/lexical#7613
- [x] facebook/lexical#7405
- [x] facebook/lexical#7420
- [x] facebook/lexical#7662

---
- To see the specific tasks where the Asana app for GitHub is being
used, see below:
  - https://app.asana.com/0/0/1211202581885926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants