This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/fbopensource/lexical/88xoJUbufXoP3sgA1XWxbc5Rom1F
✅ Preview: https://lexical-git-post-transform-2-fbopensource.vercel.app

Yeah, it seems like current API can solve all cases we've discussed. In the worst case you can always manipulate raw dom node and update it before it's converted into lexical node. I'd say this PR still has valuable change - to pass childLexicalNodes instead of all lexicalNodes (which might include non-child nodes). As you've mentioned even currentLexicalNode is not needed as after argument, as conversion fn has access to it from closure. So it can remain as simple as(lexicalChildren: Array<LexicalNode>) => Array<LexicalNode>.

Please can I request you get together and do a tech talk on this logic please? I’d love to understand it all fully.

Please can I request you get together and do a tech talk on this logic please? I’d love to understand it all fully.

Definitely - I was planning to do this since others were also interested. Will set something up for next week.

Yeah, it seems like current API can solve all cases we've discussed. In the worst case you can always manipulate raw dom node and update it before it's converted into lexical node. I'd say this PR still has valuable change - to pass childLexicalNodes instead of all lexicalNodes (which might include non-child nodes). As you've mentioned even currentLexicalNode is not needed as after argument, as conversion fn has access to it from closure. So it can remain as simple as(lexicalChildren: Array) => Array.

I was thinking about this more - the argument currentLexicalNode is the domNode after it has been transformed to Lexical, This isn't available in the outer function scope, but might be useful if you wanted to make some changes to the children based on the nature of the parent LexicalNode. For instance, in the case of Lists, maybe we want to check that all immediate children are ListItemNodes if their parent is a ListNode.

You should be able to access it, or is it wrong example?

  ul: (domNode: Node) => {
    const listNode = $createListNode();

    return {
      node: listNode,  // <-- used to set currentLexicalNode value
      after: (childLexicalNodes) => {
        ... check "listNode" if needed ...
        return childLexicalNodes;
      },
    };
  },
	

You should be able to access it, or is it wrong example?

  ul: (domNode: Node) => {
    const listNode = $createListNode();

    return {
      node: listNode,  // <-- used to set currentLexicalNode value
      after: (childLexicalNodes) => {
        ... check "listNode" if needed ...
        return childLexicalNodes;
      },
    };
  },
	

Lol no, you're exactly right - I don't know what I was thinking.