Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/fbopensource/lexical/EANJ4v4WaPgzuGcw5R84QcPWcWma |
d9a943a to
f633732
Compare
Collaborator
Author
|
Fixes #1042 |
f633732 to
a3a5635
Compare
Collaborator
Author
|
Added GH table-based markup support, which does not look that bad code-wise with new API |
c97f375 to
c4e39db
Compare
c4e39db to
325129f
Compare
acywatson
pushed a commit
that referenced
this pull request
Jan 22, 2022
* Add code detecting and e2e tests * Add quip paste * Add github table-based code pasting
acywatson
added a commit
that referenced
this pull request
Jan 22, 2022
…sting (#1153) * wip * wip * add postTransform to HTML paste logic * Add code pasting support (#1159) * Add code detecting and e2e tests * Add quip paste * Add github table-based code pasting * remove dom node from post-processor signature * fix rebase issue Co-authored-by: Maksim Horbachevsky <fantactuka@gmail.com>
acywatson
pushed a commit
that referenced
this pull request
Jan 30, 2022
* Add code detecting and e2e tests * Add quip paste * Add github table-based code pasting
acywatson
added a commit
that referenced
this pull request
Jan 31, 2022
…nature (#1160) * wip * wip * add postTransform to HTML paste logic * Add code pasting support (#1159) * Add code detecting and e2e tests * Add quip paste * Add github table-based code pasting * Change post-transform API to accomodate changing the currentLexicalNode * simplify function signature in HTMl paste post-processor * rebase fixes Co-authored-by: Maksim Horbachevsky <fantactuka@gmail.com>
acywatson
added a commit
that referenced
this pull request
Apr 9, 2022
…sting (#1153) * wip * wip * add postTransform to HTML paste logic * Add code pasting support (#1159) * Add code detecting and e2e tests * Add quip paste * Add github table-based code pasting * remove dom node from post-processor signature * fix rebase issue Co-authored-by: Maksim Horbachevsky <fantactuka@gmail.com>
acywatson
added a commit
that referenced
this pull request
Apr 9, 2022
…nature (#1160) * wip * wip * add postTransform to HTML paste logic * Add code pasting support (#1159) * Add code detecting and e2e tests * Add quip paste * Add github table-based code pasting * Change post-transform API to accomodate changing the currentLexicalNode * simplify function signature in HTMl paste post-processor * rebase fixes Co-authored-by: Maksim Horbachevsky <fantactuka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some e2e tests for different editors / text surfaces (VSCode, Codehub, Webstorm, Slack, Notion) with basic code detection (for now it's
font-family: monospacethat seem to be common). The only outlier is Github which outputs code with<table>and will require special handling logic if we decide to support it