Use faasmctl
#785
Merged
Use faasmctl
#785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #785 +/- ##
==========================================
- Coverage 67.48% 67.44% -0.04%
==========================================
Files 69 69
Lines 7762 7762
==========================================
- Hits 5238 5235 -3
- Misses 2524 2527 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR officially ditches the old
./bin/cli.shapproach to starting development cluster and switches tofaasmctl.faasmctlis a command line tool used to interact with a running Faasm cluster. It has been used as part of GHA for a while, and now I update the docs to include it.By using
faasmctlwe move all the logic of interacting with a running Faasm cluster from./faasmcli/to a different repository. This also means that any interaction with the HTTP endpoints should be done either through thefaasmctlscript, or the API that it exposes. Note thatfaasmctlis installed withpipas part ofsource ./bin/workon.sh.This means, that now before doing anything in Faasm, we always need to activate the virtual environment:
source ./bin/workon.sh faasmctl --versionavoiding the confusion about what is mounted and what is not.
In a subsequent PR I will remove all the tasks in
./faasmclithat are now obsolete, and leave the rest (generally true development tasks) in the usual./tasks.Closes #636
Closes #722