Move ./bin/cli.sh to an invoke task
#722
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
865a7e0 to
de13250
Compare
2c8ba5d to
e538c8c
Compare
./bin/cli.sh and mount checked-out code in quick start tests
./bin/cli.sh and mount checked-out code in quick start tests./bin/cli.sh to inv
./bin/cli.sh to inv./bin/cli.sh to an invoke task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I make two important changes to the way we interact with Faasm.
First, I move the
./bin/cli.shbash script to an invoke task. This solves a long-running, recurring, error newcomers to Faasm where facing: even though you need to activate the virtual environment to start a cluster, you can not start the CLI container from a virtual-environment-activated shell (see #636). (NB: the migration to python does not actually solve the issue, but given that I had to modify the script, I prefered to port it to Python tasks).In addition, I modify the
clustertask (and thequick-starttest) to also run a cluster with the latest code version (not the latest tag). This can be enabled/disabled with theinv cluster.start [--detached]flag.Closes #636