Skip to content

Conversation

@csegarragonz
Copy link
Collaborator

@csegarragonz csegarragonz commented Nov 14, 2022

In this PR, I bump the Faasm ecossytem to use LLVM 13 all around. This means that we use LLVM 13 to cross-compile to WebAssembly, and to build our WASM runtimes (WAVM and WAMR). The latter is usually the trickiest bit, as WASM runtimes implement optimizations (specially when generating AOT binary code), which are tightly coupled with LLVM. In the case of WAMR, its usually a matter of bumping to the latest commit. In the case of WAVM, it involves some fiddling as the library is less maintained.

Below is a list of the requirements for the merge. I keep it for reference, whenever we upgrade the LLVM version again.

To-Do:

Before merging:

  • Examples building with LLVM 13: LLVM 13 examples#2
  • Merge all PRs and update submodules in faasm/faasm

After merging:

  • Re-tag examples for latest containers.

Closes #690
Closes #642 (superseeded)

This was referenced Nov 15, 2022
@csegarragonz csegarragonz self-assigned this Nov 16, 2022
@csegarragonz csegarragonz marked this pull request as ready for review November 16, 2022 18:32
@csegarragonz csegarragonz mentioned this pull request Nov 17, 2022
@csegarragonz csegarragonz force-pushed the llvm branch 5 times, most recently from 493f541 to 1014eea Compare November 21, 2022 09:48
@csegarragonz csegarragonz marked this pull request as draft December 5, 2022 16:43
@csegarragonz csegarragonz force-pushed the llvm branch 2 times, most recently from eb54525 to 3e4b119 Compare December 16, 2022 14:41
@csegarragonz csegarragonz marked this pull request as ready for review December 22, 2022 13:52
@csegarragonz
Copy link
Collaborator Author

csegarragonz commented Jan 9, 2023

Tests are finally green! 🥲

@Shillaker will request reviews everywhere, you can use this PR's description as guideline.

@csegarragonz csegarragonz requested a review from Shillaker January 9, 2023 11:56
@csegarragonz csegarragonz merged commit 5fd3af3 into main Jan 18, 2023
@csegarragonz csegarragonz deleted the llvm branch January 18, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix spurious WAVM failures in the tests

3 participants