LLVM 13 #285
Merged
LLVM 13 #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
commented
Nov 16, 2022
| REDIS_STATE_HOST: redis | ||
| ASAN_OPTIONS: "verbosity=1:halt_on_error=1" | ||
| TSAN_OPTIONS: "verbosity=1:halt_on_error=1:suppressions=/code/faabric/thread-sanitizer-ignorelist.txt:history_size=7" | ||
| TSAN_OPTIONS: "verbosity=1 halt_on_error=1 suppressions=./thread-sanitizer-ignorelist.txt history_size=4" |
Collaborator
Author
There was a problem hiding this comment.
We need this path to be relative to the working directory, to allow the tests to run on any checked-out path (i.e. GHA with actions/checkout).
csegarragonz
commented
Nov 16, 2022
| # TODO: Remove: There's something weird going on with MPI code I don't understand | ||
| race:faabric::scheduler::MpiWorld::* | ||
|
|
||
| # Race in ReaderWriterQueue |
Collaborator
Author
There was a problem hiding this comment.
This appeared as I fixed the TSAN_FLAGS.
Shillaker
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upgrade to LLVM 13, we don't need to install
clang-*10packages. This PR updates thefaabric-baseimages and bumps the code to version0.4.0.See faasm/faasm#705 for the big picture.