feat(aws): parametersstore support for aws tags#4967
Merged
Skarlso merged 8 commits intoexternal-secrets:mainfrom Jul 2, 2025
Merged
feat(aws): parametersstore support for aws tags#4967Skarlso merged 8 commits intoexternal-secrets:mainfrom
Skarlso merged 8 commits intoexternal-secrets:mainfrom
Conversation
d9bcfc9 to
6a8b4ee
Compare
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
6a8b4ee to
6ba122e
Compare
Contributor
Author
|
Hi @Skarlso, have a look when you have time |
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Contributor
|
will take a look at this tomorrow |
Skarlso
reviewed
Jul 2, 2025
Skarlso
reviewed
Jul 2, 2025
Skarlso
reviewed
Jul 2, 2025
Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Ivan Ka <5395690+ivankatliarchuk@users.noreply.github.com>
Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Skarlso
approved these changes
Jul 2, 2025
Contributor
|
@ivankatliarchuk You need to update the branch then it's good to go. |
|
Contributor
Author
|
Sure. Done |
alliseeisgold
pushed a commit
to alliseeisgold/external-secrets
that referenced
this pull request
Jul 10, 2025
* feat(aws): parametersstore support for aws tags Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com> * feat(aws): parametersstore support for aws tags Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com> * feat(aws): parametersstore support for aws tags Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com> * feat(aws): parametersstore support for aws tags Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com> * feat(aws): parametersstore support for aws tags Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com> * feat(aws): parametersstore support for aws tags Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Ivan Ka <5395690+ivankatliarchuk@users.noreply.github.com> * feat(aws): parametersstore support for aws tags Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com> --------- Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com> Signed-off-by: Ivan Ka <5395690+ivankatliarchuk@users.noreply.github.com> Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: asrormirzoev <asrormirzoev@yandex-team.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem Statement
What is the problem you're trying to solve?
Related Issue
Fixes #4701
Follow-up #1821 as currently tags added only on new secret creation.
Proposed Changes
How do you like to solve the issue and why?
Added support
Checklist
git commit --signoffmake testmake reviewableSmoke testing
Created (with tags)
Added extra tag(s) and modified tag
Deleted few tags
Deleted all tags (only required managed tags left)
Added tags back in
