Revert "3012 - Probes for external-secrets"#3213
Merged
Conversation
This reverts commit 7eebfa0. Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
5474c1f to
459ae3f
Compare
|
Contributor
Author
|
Not sure why Helm is failing since it's a revert. |
IdanAdar
approved these changes
Mar 1, 2024
Contributor
You should not revert the whole commit, otherwise you don't fix the issues with onboardbase and fortanix snapshots. At least that's my interpretation here: FAIL test crds deploy/charts/external-secrets/tests/crds_test.yaml
- should match snapshot of default values
- asserts[0] `matchSnapshot` fail
Template: external-secrets/templates/crds/secretstore.yaml
DocumentIndex: 0
Path:
Expected to match snapshot 1:
--- Expected
+++ Actual
@@ -2417,2 +2417,30 @@
type: object
+ fortanix:
+ description: Fortanix configures this store to sync secrets using the Fortanix provider
+ properties:
+ apiKey:
+ description: APIKey is the API token to access SDKMS Applications.
+ properties:
+ secretRef:
+ description: SecretRef is a reference to a secret containing the SDKMS API Key.
+ properties:
+ key:
+ description: |-
+ The key of the entry in the Secret resource's `data` field to be used. Some instances of this field may be
+ defaulted, in others it may be required.
+ type: string
+ name:
+ description: The name of the Secret resource being referred to.
+ type: string
+ namespace: |
Contributor
|
Damn it, I was a bit too late 😄 You just merged |
Contributor
Author
|
Argh :D |
Contributor
Author
|
It's okay, I guess we'll fix that in a separate commit. |
Contributor
I'll quickly do it, I gained some experience during this week 😄 |
Contributor
Author
|
Thanks! :D :D Much appreciated. :D |
Contributor
Here we go: #3215 |
Bude8
pushed a commit
to Bude8/external-secrets
that referenced
this pull request
Jun 13, 2024
…xternal-secrets#3213) This reverts commit 7eebfa0. Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com> Signed-off-by: Bude8 <henryblee8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3131
#3212