Skip to content

issue/3214 - correct failing crds helm.tests for providers onboardbase and fortanix#3215

Merged
Skarlso merged 1 commit intoexternal-secrets:mainfrom
fdberlking:issue/3214
Mar 1, 2024
Merged

issue/3214 - correct failing crds helm.tests for providers onboardbase and fortanix#3215
Skarlso merged 1 commit intoexternal-secrets:mainfrom
fdberlking:issue/3214

Conversation

@fdberlking
Copy link
Copy Markdown
Contributor

@fdberlking fdberlking commented Mar 1, 2024 •
edited
Loading

Problem Statement

Adding missing snapshots for new providers onboardbase and fortanix.

Related Issue

Fixes #3214

Proposed Changes

Running make helm.test.update to update crds_test.yaml.snap to include latest changes for providers onboardbase and fortanix.

external-secrets git:(issue/3214) make helm.test.update 
./hack/helm.generate.sh deploy/crds deploy/charts/external-secrets
13:35:45 [ OK ] Finished generating helm chart files

### Chart [ external-secrets ] deploy/charts/external-secrets/

 PASS  test cert controller deployment  deploy/charts/external-secrets/tests/cert_controller_test.yaml
 PASS  test controller deployment       deploy/charts/external-secrets/tests/controller_test.yaml
 PASS  test crds        deploy/charts/external-secrets/tests/crds_test.yaml
 PASS  test service monitor     deploy/charts/external-secrets/tests/service_monitor_test.yaml
 PASS  test webhook deployment  deploy/charts/external-secrets/tests/webhook_test.yaml

Charts:      1 passed, 1 total
Test Suites: 5 passed, 5 total
Tests:       39 passed, 39 total
Snapshot:    5 passed, 5 total
Time:        466.311947ms

➜  external-secrets git:(issue/3214) ✗ make helm.test
./hack/helm.generate.sh deploy/crds deploy/charts/external-secrets
13:35:58 [ OK ] Finished generating helm chart files

### Chart [ external-secrets ] deploy/charts/external-secrets/

 PASS  test cert controller deployment  deploy/charts/external-secrets/tests/cert_controller_test.yaml
 PASS  test controller deployment       deploy/charts/external-secrets/tests/controller_test.yaml
 PASS  test crds        deploy/charts/external-secrets/tests/crds_test.yaml
 PASS  test service monitor     deploy/charts/external-secrets/tests/service_monitor_test.yaml
 PASS  test webhook deployment  deploy/charts/external-secrets/tests/webhook_test.yaml

Charts:      1 passed, 1 total
Test Suites: 5 passed, 5 total
Tests:       39 passed, 39 total
Snapshot:    5 passed, 5 total
Time:        456.30247ms

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • Building the operator binary and docker image with make build
  • All tests pass with make lint
  • All tests pass with make test
  • All tests pass with make check-diff
  • All tests pass with make docs
  • All tests pass with make helm.docs
  • All tests pass with make helm.test.update
  • All tests pass with make helm.test
  • I ensured my PR is ready for review with make reviewable

issue/3214 - running make helm.test-update to deploy new test crds
cefca97 
Signed-off-by: Benjamin Walterscheid <benjamin.walterscheid@de.ibm.com>
@fdberlking fdberlking requested a review from a team as a code owner March 1, 2024 13:06
@fdberlking fdberlking requested a review from knelasevero March 1, 2024 13:06
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@fdberlking fdberlking mentioned this pull request Mar 1, 2024
Merged
@Skarlso Skarlso merged commit 91139d0 into external-secrets:main Mar 1, 2024
@Skarlso
Copy link
Copy Markdown
Contributor

Skarlso commented Mar 1, 2024

Thanks for the quick fix! :)

Bude8 pushed a commit to Bude8/external-secrets that referenced this pull request Jun 13, 2024
@fdberlking @Bude8
issue/3214 - running make helm.test-update to deploy new test crds (e…
ddd0ae5 
…xternal-secrets#3215)

Signed-off-by: Benjamin Walterscheid <benjamin.walterscheid@de.ibm.com>
Co-authored-by: Benjamin Walterscheid <benjamin.walterscheid@de.ibm.com>
Signed-off-by: Bude8 <henryblee8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skarlso Skarlso Skarlso approved these changes

@knelasevero knelasevero Awaiting requested review from knelasevero knelasevero was automatically assigned from external-secrets/maintainers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Correct failing crds helm.tests for providers onboardbase and fortanix

2 participants

@fdberlking @Skarlso