Merged
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: c558433 Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-audio/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "1cd0d495d6e413bb5d360a2dacd330f39f79cae2"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-audio/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "09bf27ca49fddc7548516252fdad7e10a2ce791f"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-audio/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "7483c01f05528676ffaddc1106f124e14532de18"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-audio/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "dc19b7c91768bb26b185907ae492b2b994b718af"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-image/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "cbf9f66cd9364ef40c91e0c1dc1eff74089fe57c"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-image/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "e7f03fbc5f52732f66a401867fecb0ddb07534f1"
}
}
]Generated by PR labeler 🤖 |
298dec1 to
ba2c7f0
Compare
ba2c7f0 to
d6824ba
Compare
7efb47c to
e7f5871
Compare
19e8cce to
f4ea64a
Compare
e7f5871 to
f247fb7
Compare
f4ea64a to
aec5401
Compare
27aa220 to
1e5072c
Compare
aec5401 to
07e6c57
Compare
Contributor
|
@alanjhughes I want to note one thing about exactly "web" env: for web env you did almost the same that was done already: https://github.com/expo/expo/blob/main/packages/expo-audio/src/ExpoAudio.web.ts#L35-L58 that code preloads audio as
Why partially? because of buffering on web can be done via This means some code for "web" is already have been done but not enough and that code is duplicated 2 times. I think need to combine your code with P.S. Native still doesnt have any change of buffering. This comments is only about web |
1e5072c to
a1564cc
Compare
07e6c57 to
b0b45ce
Compare
Collaborator
Author
|
@psnet - This is a draft PR and still being worked on. Also, it is part of a stack of PRs. See #43063 (comment) for the others with the native changes. |
b0b45ce to
0412274
Compare
Contributor
|
Subscribed to pull request
Generated by CodeMention |
a1564cc to
c3a4c23
Compare
4dab893 to
ef131e5
Compare
1cd63f6 to
d9b1ca3
Compare
ef131e5 to
fa5d9aa
Compare
d9b1ca3 to
eb816a2
Compare
fa5d9aa to
fd2709f
Compare
eb816a2 to
d4df148
Compare
997a625 to
7a39d85
Compare
d4df148 to
a851c36
Compare
lukmccall
approved these changes
Feb 17, 2026
| }) | ||
| .catch(() => { | ||
| if (!isCancelled) { | ||
| player.replace(resolved); |
Contributor
There was a problem hiding this comment.
It's weird that we're replacing the source with an unsuccessful preload. Was that intentional?
Collaborator
Author
There was a problem hiding this comment.
It's not replacing with an unsuccessful preload, it's just using the original source url if it fails. When it goes through _createMediaElement the cache will be checked. It won't be there in this case so we just load it normally. I'll make it a finally block so there's no duplication
a851c36 to
956a40a
Compare
40c2830 to
3010269
Compare
956a40a to
6fff3e3
Compare
3915d03 to
84762f9
Compare
6fff3e3 to
4ea9f60
Compare
84762f9 to
6777fb0
Compare
0988b69 to
d1fa2c4
Compare
6777fb0 to
bfcd976
Compare
Collaborator
Author
Merge activity
|
bfcd976 to
2fdc151
Compare
benjaminkomen
pushed a commit
to benjaminkomen/expo
that referenced
this pull request
Feb 25, 2026
# Why Supports preloading on web # How Same approach as when `downloadFirst` was added except we also add `audio.preload = 'auto';` Extracted some of the shared logic from `downloadFirst` so all forms of preloading go through the same mechanism and use the cache. # Test Plan Bare expo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Supports preloading on web
How
Same approach as when
downloadFirstwas added except we also addaudio.preload = 'auto';Extracted some of the shared logic fromdownloadFirstso all forms of preloading go through the same mechanism and use the cache.Test Plan
Bare expo.